starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14750] [MERGED] Fixes #14241, Fixes #13922: Update the CableRender #14446

New Issue
Closed
opened 2025-12-29 23:24:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14750
Author: @Moehritz
Created: 1/9/2024
Status: ✅ Merged
Merged: 4/23/2024
Merged by: @DanSheps

Base: develop ← Head: 13922-svg-uneven

📝 Commits (3)

  • 6af3aad Fixes #14722, Fixes #13922: Update the CableRender
  • ced4483 Remove dangling logging message used during development
  • 2c93dd0 account for swapped terminations in cable object

📊 Changes

1 file changed (+174 additions, -195 deletions)

View changed files

📝 netbox/dcim/svg/cables.py (+174 -195)

📄 Description

Fixes: #14241, Fixes: #13922

This commit updates the cable rendering logic to fix both issue #14241 and #13922. Before, objects, terminations and cables where drawn in the svg without context of each other.
Now the following changes are applied:

  • Hosts and Terminations are where possible sorted alphabetically
  • Terminations and Cables are visually connected, and if necessary not in a vertical line
  • Terminations and Hosts are visually aligning
  • Cable Tooltips contain more information

Before:
image
After:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14750 **Author:** [@Moehritz](https://github.com/Moehritz) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 4/23/2024 **Merged by:** [@DanSheps](https://github.com/DanSheps) **Base:** `develop` ← **Head:** `13922-svg-uneven` --- ### 📝 Commits (3) - [`6af3aad`](https://github.com/netbox-community/netbox/commit/6af3aad36262713c22647f7f9d2565e038ae0b02) Fixes #14722, Fixes #13922: Update the CableRender - [`ced4483`](https://github.com/netbox-community/netbox/commit/ced44832f75913f93a7768e9ee001f1e313bb545) Remove dangling logging message used during development - [`2c93dd0`](https://github.com/netbox-community/netbox/commit/2c93dd03e12acd0c9754d6e051166dcdd59d6329) account for swapped terminations in cable object ### 📊 Changes **1 file changed** (+174 additions, -195 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/svg/cables.py` (+174 -195) </details> ### 📄 Description ### Fixes: #14241, Fixes: #13922 This commit updates the cable rendering logic to fix both issue #14241 and #13922. Before, objects, terminations and cables where drawn in the svg without context of each other. Now the following changes are applied: - Hosts and Terminations are where possible sorted alphabetically - Terminations and Cables are visually connected, and if necessary not in a vertical line - Terminations and Hosts are visually aligning - Cable Tooltips contain more information Before: ![image](https://github.com/netbox-community/netbox/assets/1659422/82d7a90b-399d-4d83-8c77-b8657881714d) After: ![image](https://github.com/netbox-community/netbox/assets/1659422/c9053799-9f25-4892-92ca-bb63bc1d10a5) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:31 +01:00
adam closed this issue 2025-12-29 23:24:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?