starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14470] [MERGED] 13983 Add nested arrays for extra_choices in CustomFieldChoiceSet #14395

New Issue
Closed
opened 2025-12-29 23:24:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14470
Author: @arthanson
Created: 12/7/2023
Status: ✅ Merged
Merged: 12/14/2023
Merged by: @jeremystretch

Base: develop ← Head: 13983-csv-string-delimiter3

📝 Commits (9)

  • 686633f 13983 split array fields in CSV data for CustomFieldChoices
  • d677dd8 13983 fix help text
  • 4cdc64c 13983 update tests
  • a533275 Merge branch 'develop' into 13983-csv-string-delimiter3
  • 5c01770 13983 use re for split
  • f509c65 13983 replace escaped chars
  • f49c310 13983 fix escape handling
  • e13dd5d 13983 fix escape handling
  • ef76833 13983 fix escape handling

📊 Changes

3 files changed (+42 additions, -4 deletions)

View changed files

📝 netbox/extras/forms/bulk_import.py (+19 -1)
📝 netbox/extras/forms/model_forms.py (+14 -0)
📝 netbox/extras/tests/test_views.py (+9 -3)

📄 Description

Fixes: #13983

Relies on change in #14469 Allows to specify multiple choices and labels for CSV import of extra_choices - just quote the whole field: "choice1:First Choice,choice2:Second Choice"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14470 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 12/14/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13983-csv-string-delimiter3` --- ### 📝 Commits (9) - [`686633f`](https://github.com/netbox-community/netbox/commit/686633f048de15f1471fef2e9621180cbd5fcc84) 13983 split array fields in CSV data for CustomFieldChoices - [`d677dd8`](https://github.com/netbox-community/netbox/commit/d677dd8b5a04614cca2919d25c618321df81932a) 13983 fix help text - [`4cdc64c`](https://github.com/netbox-community/netbox/commit/4cdc64c3e36cf29694a001f02a425a1c5eb84c48) 13983 update tests - [`a533275`](https://github.com/netbox-community/netbox/commit/a5332756496cc2fc70ad3f1e66f300b6260badd2) Merge branch 'develop' into 13983-csv-string-delimiter3 - [`5c01770`](https://github.com/netbox-community/netbox/commit/5c0177049bdfed75aaa977031827703d9af83cae) 13983 use re for split - [`f509c65`](https://github.com/netbox-community/netbox/commit/f509c65f3d8f2e6254d2a24aed971ccbcb394239) 13983 replace escaped chars - [`f49c310`](https://github.com/netbox-community/netbox/commit/f49c310f23f3bb0c895e461690354f21a2d2d2ed) 13983 fix escape handling - [`e13dd5d`](https://github.com/netbox-community/netbox/commit/e13dd5d905b83532ac7b7500a1d1b7796a3dd8df) 13983 fix escape handling - [`ef76833`](https://github.com/netbox-community/netbox/commit/ef768335c1dab98e9b7795b66bc198115d339d0e) 13983 fix escape handling ### 📊 Changes **3 files changed** (+42 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/forms/bulk_import.py` (+19 -1) 📝 `netbox/extras/forms/model_forms.py` (+14 -0) 📝 `netbox/extras/tests/test_views.py` (+9 -3) </details> ### 📄 Description ### Fixes: #13983 Relies on change in #14469 Allows to specify multiple choices and labels for CSV import of extra_choices - just quote the whole field: "choice1:First Choice,choice2:Second Choice" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:13 +01:00
adam closed this issue 2025-12-29 23:24:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?