starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14469] [MERGED] 14467 change ChoiceField separator from comma to colon #14394

New Issue
Closed
opened 2025-12-29 23:24:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14469
Author: @arthanson
Created: 12/7/2023
Status: ✅ Merged
Merged: 12/12/2023
Merged by: @jeremystretch

Base: develop ← Head: 14467-choiceset-colon

📝 Commits (5)

  • 8d4001e 14467 change ChoiceField separator from comma to colon
  • 010721e 14467 fix test
  • df82f78 14467 fix test
  • 855c32a 14467 use regex for colon detection
  • ff343dc 14467 update tests

📊 Changes

3 files changed (+13 additions, -5 deletions)

View changed files

📝 netbox/extras/forms/model_forms.py (+4 -3)
📝 netbox/extras/tests/test_views.py (+8 -1)
📝 netbox/utilities/forms/widgets/misc.py (+1 -1)

📄 Description

Fixes: #14467

Changes the ChoiceField (for CustomFieldChoiceSetForm extra_choices) from a comma to colon. This is to enable a clean fix for #13983

Should have no side-effects as the comma isn't stored anywhere and the change in the widget makes old saved values appear correctly with the new colon. The only potential for issue is if someone has a colon stored as part of a label/choice which should be very unlikely.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14469 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 12/12/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14467-choiceset-colon` --- ### 📝 Commits (5) - [`8d4001e`](https://github.com/netbox-community/netbox/commit/8d4001ef332f703e32c60e944c6fb8fc9cb1fdec) 14467 change ChoiceField separator from comma to colon - [`010721e`](https://github.com/netbox-community/netbox/commit/010721ed073187bfc536a770716682d7f70dcb0b) 14467 fix test - [`df82f78`](https://github.com/netbox-community/netbox/commit/df82f782be445f28cdbf2d2569bb1e00013467d5) 14467 fix test - [`855c32a`](https://github.com/netbox-community/netbox/commit/855c32a635b83fee9aaece0006ddb630cee3777d) 14467 use regex for colon detection - [`ff343dc`](https://github.com/netbox-community/netbox/commit/ff343dc031cc4ede96075ececa739b20c80b0e09) 14467 update tests ### 📊 Changes **3 files changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/forms/model_forms.py` (+4 -3) 📝 `netbox/extras/tests/test_views.py` (+8 -1) 📝 `netbox/utilities/forms/widgets/misc.py` (+1 -1) </details> ### 📄 Description ### Fixes: #14467 Changes the ChoiceField (for CustomFieldChoiceSetForm extra_choices) from a comma to colon. This is to enable a clean fix for #13983 Should have no side-effects as the comma isn't stored anywhere and the change in the widget makes old saved values appear correctly with the new colon. The only potential for issue is if someone has a colon stored as part of a label/choice which should be very unlikely. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:13 +01:00
adam closed this issue 2025-12-29 23:24:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?