starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14376] [MERGED] 14346 fix missing function call convert #14374

New Issue
Closed
opened 2025-12-29 23:24:07 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14376
Author: @isodude
Created: 11/29/2023
Status: ✅ Merged
Merged: 11/29/2023
Merged by: @jeremystretch

Base: develop ← Head: 14346-fix-missing-function-convert

📝 Commits (1)

  • e3aa291 14346 fix missing function call convert

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/extras/api/views.py (+1 -1)

📄 Description

In PR #13958 (commit 8224644) _get_report was modified to do the call on the variable without changing the call later on.

Fixes: #14346

This commit fixes that and removes the call on the variable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14376 **Author:** [@isodude](https://github.com/isodude) **Created:** 11/29/2023 **Status:** ✅ Merged **Merged:** 11/29/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14346-fix-missing-function-convert` --- ### 📝 Commits (1) - [`e3aa291`](https://github.com/netbox-community/netbox/commit/e3aa29120b78c9d88b7e4fa3497393dbf40d27aa) 14346 fix missing function call convert ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/api/views.py` (+1 -1) </details> ### 📄 Description In PR #13958 (commit 8224644) _get_report was modified to do the call on the variable without changing the call later on. ### Fixes: #14346 This commit fixes that and removes the call on the variable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:07 +01:00
adam closed this issue 2025-12-29 23:24:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?