starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14332] [CLOSED] Fixes #14329: Improve diffs for custom fields #14367

New Issue
Closed
opened 2025-12-29 23:24:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14332
Author: @JCWasmx86
Created: 11/23/2023
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (5)

📊 Changes

6 files changed (+251 additions, -39 deletions)

View changed files

📝 netbox/extras/models/change_logging.py (+2 -2)
📝 netbox/extras/views.py (+9 -9)
📝 netbox/templates/extras/objectchange.html (+3 -13)
📝 netbox/translations/en/LC_MESSAGES/django.po (+6 -6)
📝 netbox/utilities/data.py (+214 -9)
📝 netbox/utilities/templatetags/helpers.py (+17 -0)

📄 Description

Fixes: #14329

This improves the diff by comparing the changes dicts recursively. It changes the Diff and the Pre/Post-Change Data

image

That's one issue I found, but it seems unrelated, as even without my patch, the type of the floating-point field seems to change:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14332 **Author:** [@JCWasmx86](https://github.com/JCWasmx86) **Created:** 11/23/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (5) - [`46719fb`](https://github.com/netbox-community/netbox/commit/46719fb356e912357205f0044fb962b877c842c8) Fixes #14329: Improve diffs for custom fields - [`6098977`](https://github.com/netbox-community/netbox/commit/6098977ee35cc9442c4bf95bdc18d2ce85ca3a0a) More - [`292bebd`](https://github.com/netbox-community/netbox/commit/292bebdc0e8bc6bf18cc06f1cd456c6c6b599107) More - [`6196eb2`](https://github.com/netbox-community/netbox/commit/6196eb2eb6173cfb21884ce8889c76d0247ca529) Tmp with difflib - [`fe2f92c`](https://github.com/netbox-community/netbox/commit/fe2f92c97db5d53dcfab7f4ef3a4729c9295c93f) Update source translation strings ### 📊 Changes **6 files changed** (+251 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/change_logging.py` (+2 -2) 📝 `netbox/extras/views.py` (+9 -9) 📝 `netbox/templates/extras/objectchange.html` (+3 -13) 📝 `netbox/translations/en/LC_MESSAGES/django.po` (+6 -6) 📝 `netbox/utilities/data.py` (+214 -9) 📝 `netbox/utilities/templatetags/helpers.py` (+17 -0) </details> ### 📄 Description ### Fixes: #14329 This improves the diff by comparing the changes dicts recursively. It changes the Diff and the Pre/Post-Change Data ![image](https://github.com/netbox-community/netbox/assets/63594136/b25c20d6-d6ee-4862-ba71-0c84e112a54c) That's one issue I found, but it seems unrelated, as even without my patch, the type of the floating-point field seems to change: ![image](https://github.com/netbox-community/netbox/assets/63594136/a8925d3e-966a-48ed-8622-c2639fd80fdd) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:05 +01:00
adam closed this issue 2025-12-29 23:24:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?