starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14327] [MERGED] Closes #14326: Move form mixins #14363

New Issue
Closed
opened 2025-12-29 23:24:03 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:03 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14327
Author: @jeremystretch
Created: 11/22/2023
Status: ✅ Merged
Merged: 11/22/2023
Merged by: @jeremystretch

Base: feature ← Head: 14326-move-form-mixins

📝 Commits (2)

  • 025ace7 Move form mixins from extras app to netbox app
  • 2409eab Remove obsolete extras/admin.py

📊 Changes

8 files changed (+8 additions, -13 deletions)

View changed files

📝 netbox/core/forms/filtersets.py (+1 -1)
📝 netbox/dcim/forms/bulk_create.py (+2 -2)
➖ netbox/extras/admin.py (+0 -2)
📝 netbox/extras/forms/__init__.py (+0 -1)
📝 netbox/extras/forms/filtersets.py (+1 -1)
📝 netbox/netbox/forms/base.py (+1 -1)
📝 netbox/netbox/forms/mixins.py (+0 -0)
📝 netbox/users/forms/filtersets.py (+3 -5)

📄 Description

Fixes: #14326

  • Move the following classes from extras.forms.mixins to netbox.forms.mixins:
    • CustomFieldsMixin
    • SavedFiltersMixin
    • TagsMixin
  • Update import statements
  • Delete obsolete file extras/admin.py

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14327 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/22/2023 **Status:** ✅ Merged **Merged:** 11/22/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `14326-move-form-mixins` --- ### 📝 Commits (2) - [`025ace7`](https://github.com/netbox-community/netbox/commit/025ace777dc9d706e487157bdbfe873f47b5af9b) Move form mixins from extras app to netbox app - [`2409eab`](https://github.com/netbox-community/netbox/commit/2409eab4a889df9cd8a5e924f98d88c8af6110d9) Remove obsolete extras/admin.py ### 📊 Changes **8 files changed** (+8 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/forms/filtersets.py` (+1 -1) 📝 `netbox/dcim/forms/bulk_create.py` (+2 -2) ➖ `netbox/extras/admin.py` (+0 -2) 📝 `netbox/extras/forms/__init__.py` (+0 -1) 📝 `netbox/extras/forms/filtersets.py` (+1 -1) 📝 `netbox/netbox/forms/base.py` (+1 -1) 📝 `netbox/netbox/forms/mixins.py` (+0 -0) 📝 `netbox/users/forms/filtersets.py` (+3 -5) </details> ### 📄 Description ### Fixes: #14326 - Move the following classes from `extras.forms.mixins` to `netbox.forms.mixins`: - CustomFieldsMixin - SavedFiltersMixin - TagsMixin - Update `import` statements - Delete obsolete file `extras/admin.py` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:03 +01:00
adam closed this issue 2025-12-29 23:24:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?