starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14087] [MERGED] Closes #8356: Add virtual disk to Virtual Machines #14313

New Issue
Closed
opened 2025-12-29 23:23:45 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:45 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14087
Author: @arthanson
Created: 10/20/2023
Status: ✅ Merged
Merged: 11/17/2023
Merged by: @jeremystretch

Base: feature ← Head: 8356-vm-virtual-disk

📝 Commits (10+)

📊 Changes

31 files changed (+804 additions, -63 deletions)

View changed files

📝 netbox/netbox/navigation/menu.py (+1 -0)
➕ netbox/templates/virtualization/virtualdisk.html (+59 -0)
📝 netbox/templates/virtualization/virtualmachine.html (+30 -8)
📝 netbox/templates/virtualization/virtualmachine/base.html (+19 -5)
➕ netbox/templates/virtualization/virtualmachine/virtual_disks.html (+14 -0)
📝 netbox/templates/virtualization/virtualmachine_list.html (+7 -0)
📝 netbox/virtualization/api/nested_serializers.py (+11 -1)
📝 netbox/virtualization/api/serializers.py (+20 -3)
📝 netbox/virtualization/api/urls.py (+1 -0)
📝 netbox/virtualization/api/views.py (+12 -2)
📝 netbox/virtualization/apps.py (+1 -1)
📝 netbox/virtualization/filtersets.py (+28 -1)
📝 netbox/virtualization/forms/bulk_create.py (+9 -1)
📝 netbox/virtualization/forms/bulk_edit.py (+34 -0)
📝 netbox/virtualization/forms/bulk_import.py (+15 -0)
📝 netbox/virtualization/forms/filtersets.py (+21 -0)
📝 netbox/virtualization/forms/model_forms.py (+32 -6)
📝 netbox/virtualization/forms/object_create.py (+12 -1)
📝 netbox/virtualization/graphql/schema.py (+6 -0)
📝 netbox/virtualization/graphql/types.py (+12 -0)

...and 11 more files

📄 Description

Fixes: #8356

introduces a new VirtualDisk model with name and size fields, instances of which must be assigned to a specific virtual machine. Retains the existing disk field on VirtualMachine.

Switched Virtual Machine list view to show Disk Size (from Virtual Disks) instead of Disk - made it default, but user can add disks back if needed. I think this makes it very clear that they should be moved.

Also put in deprecation warnings for Disk in detail / edit view:

Monosnap Editing virtual machine vm1 | NetBox 2023-10-23 11-22-17
Monosnap vm1 | NetBox 2023-10-23 11-24-08

Added Virtual Disks to end of Virtual Machine detail view:
Monosnap vm1 | NetBox 2023-10-24 10-13-32

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14087 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/20/2023 **Status:** ✅ Merged **Merged:** 11/17/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `8356-vm-virtual-disk` --- ### 📝 Commits (10+) - [`5bcf351`](https://github.com/netbox-community/netbox/commit/5bcf351bdc05f9e97fd4bce1d210466d494a5193) 8356 add virtual disk model - [`12861a1`](https://github.com/netbox-community/netbox/commit/12861a19a8c3a5ad0deea9eac96fa6776bb6c1f2) 8356 add supplemental forms - [`4aeb4d0`](https://github.com/netbox-community/netbox/commit/4aeb4d001c5777aeeda4af036782520dea0288b2) 8356 add menu - [`4206809`](https://github.com/netbox-community/netbox/commit/42068090f0d3a41e61b522b03b6894648d28b2e6) 8356 cleanup views - [`b2bb6f6`](https://github.com/netbox-community/netbox/commit/b2bb6f68a204386685f0b266b6db14193a8c6ff6) 8356 virtual machine tab - [`42abd90`](https://github.com/netbox-community/netbox/commit/42abd90c073f6b5a62f1b364b6de531fd120e017) 8356 migrations - [`3f59539`](https://github.com/netbox-community/netbox/commit/3f59539ff3e00fb5248d352568432f8db9383970) 8356 vm disk tables - [`fc6897d`](https://github.com/netbox-community/netbox/commit/fc6897d7c2b33b4b42db6ff8eca0f907086cb00f) 8356 cleanup - [`1da0028`](https://github.com/netbox-community/netbox/commit/1da002812a47455d2b2db566572f04f1fd1ef63e) 8356 graphql - [`63f9185`](https://github.com/netbox-community/netbox/commit/63f91851dc07cd7e868afb2f093c5dd52a8ed9e3) 8356 graphql ### 📊 Changes **31 files changed** (+804 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/navigation/menu.py` (+1 -0) ➕ `netbox/templates/virtualization/virtualdisk.html` (+59 -0) 📝 `netbox/templates/virtualization/virtualmachine.html` (+30 -8) 📝 `netbox/templates/virtualization/virtualmachine/base.html` (+19 -5) ➕ `netbox/templates/virtualization/virtualmachine/virtual_disks.html` (+14 -0) 📝 `netbox/templates/virtualization/virtualmachine_list.html` (+7 -0) 📝 `netbox/virtualization/api/nested_serializers.py` (+11 -1) 📝 `netbox/virtualization/api/serializers.py` (+20 -3) 📝 `netbox/virtualization/api/urls.py` (+1 -0) 📝 `netbox/virtualization/api/views.py` (+12 -2) 📝 `netbox/virtualization/apps.py` (+1 -1) 📝 `netbox/virtualization/filtersets.py` (+28 -1) 📝 `netbox/virtualization/forms/bulk_create.py` (+9 -1) 📝 `netbox/virtualization/forms/bulk_edit.py` (+34 -0) 📝 `netbox/virtualization/forms/bulk_import.py` (+15 -0) 📝 `netbox/virtualization/forms/filtersets.py` (+21 -0) 📝 `netbox/virtualization/forms/model_forms.py` (+32 -6) 📝 `netbox/virtualization/forms/object_create.py` (+12 -1) 📝 `netbox/virtualization/graphql/schema.py` (+6 -0) 📝 `netbox/virtualization/graphql/types.py` (+12 -0) _...and 11 more files_ </details> ### 📄 Description ### Fixes: #8356 introduces a new `VirtualDisk` model with `name` and `size` fields, instances of which must be assigned to a specific virtual machine. Retains the existing `disk` field on VirtualMachine. Switched Virtual Machine list view to show Disk Size (from Virtual Disks) instead of Disk - made it default, but user can add disks back if needed. I think this makes it very clear that they should be moved. Also put in deprecation warnings for Disk in detail / edit view: ![Monosnap Editing virtual machine vm1 | NetBox 2023-10-23 11-22-17](https://github.com/netbox-community/netbox/assets/99642/14364809-5fe9-4f7f-b77d-f4eb13781016) ![Monosnap vm1 | NetBox 2023-10-23 11-24-08](https://github.com/netbox-community/netbox/assets/99642/0434bb31-eb6d-4d30-93b1-2801370cb67f) Added Virtual Disks to end of Virtual Machine detail view: ![Monosnap vm1 | NetBox 2023-10-24 10-13-32](https://github.com/netbox-community/netbox/assets/99642/34f06214-1a38-4fee-943b-746415e1caeb) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:45 +01:00
adam closed this issue 2025-12-29 23:23:45 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?