starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14028] [MERGED] 14013 fix device role filter #14298

New Issue
Closed
opened 2025-12-29 23:23:40 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14028
Author: @arthanson
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/13/2023
Merged by: @jeremystretch

Base: develop ← Head: 14013-inventory-item-filter

📝 Commits (1)

  • 0047d34 14013 fix device role filter

📊 Changes

1 file changed (+11 additions, -11 deletions)

View changed files

📝 netbox/dcim/forms/filtersets.py (+11 -11)

📄 Description

Fixes: #14013

InventoryItem had double role_id in the filter as it has one and the device has one defined, refactored the device one from using role_id to device_role_id to make it consistent with the other role filters "device_type_id", "device_id".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14028 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/13/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14013-inventory-item-filter` --- ### 📝 Commits (1) - [`0047d34`](https://github.com/netbox-community/netbox/commit/0047d34279e04d32dd320604dcf0392026f77944) 14013 fix device role filter ### 📊 Changes **1 file changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/filtersets.py` (+11 -11) </details> ### 📄 Description ### Fixes: #14013 InventoryItem had double role_id in the filter as it has one and the device has one defined, refactored the device one from using role_id to device_role_id to make it consistent with the other role filters "device_type_id", "device_id". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:40 +01:00
adam closed this issue 2025-12-29 23:23:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?