starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13949] [MERGED] 13972 allow filtering of cables if have terminations #14287

New Issue
Closed
opened 2025-12-29 23:23:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13949
Author: @arthanson
Created: 10/2/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @jeremystretch

Base: develop ← Head: 10769-cable-delete

📝 Commits (5)

  • d56b29e 10769 allow filtering of cables if have terminations
  • edae010 Merge branch 'develop' into 10769-cable-delete
  • acfaa8c 10769 change to termianted
  • fb2d037 10769 add test case
  • b616953 10769 review cleanup

📊 Changes

3 files changed (+35 additions, -1 deletions)

View changed files

📝 netbox/dcim/filtersets.py (+17 -0)
📝 netbox/dcim/forms/filtersets.py (+8 -1)
📝 netbox/dcim/tests/test_filtersets.py (+10 -0)

📄 Description

Fixes: #13972

Changed from bug #10769 to resolving FR #13972 - this allows filtering of unterminated cables (either A, B or both). Even if #10769 is done to remove cables when the last termination is deleted, this still leaves unterminated cables either from before the functionality or if the deletion is done via the API, hence the FR and this PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13949 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/2/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10769-cable-delete` --- ### 📝 Commits (5) - [`d56b29e`](https://github.com/netbox-community/netbox/commit/d56b29e502d1794c7019d835e79086efc881d15c) 10769 allow filtering of cables if have terminations - [`edae010`](https://github.com/netbox-community/netbox/commit/edae010837a78a40eeba68cb697b47c955b7fead) Merge branch 'develop' into 10769-cable-delete - [`acfaa8c`](https://github.com/netbox-community/netbox/commit/acfaa8cf4b4281a0718caf81adf466170b985806) 10769 change to termianted - [`fb2d037`](https://github.com/netbox-community/netbox/commit/fb2d037ed973d00b5063afa5c37a1bdf772b0811) 10769 add test case - [`b616953`](https://github.com/netbox-community/netbox/commit/b616953fd3dc9e895b5d220b400755a5ff03c94b) 10769 review cleanup ### 📊 Changes **3 files changed** (+35 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/filtersets.py` (+17 -0) 📝 `netbox/dcim/forms/filtersets.py` (+8 -1) 📝 `netbox/dcim/tests/test_filtersets.py` (+10 -0) </details> ### 📄 Description ### Fixes: #13972 Changed from bug #10769 to resolving FR #13972 - this allows filtering of unterminated cables (either A, B or both). Even if #10769 is done to remove cables when the last termination is deleted, this still leaves unterminated cables either from before the functionality or if the deletion is done via the API, hence the FR and this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:37 +01:00
adam closed this issue 2025-12-29 23:23:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14287
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?