starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13889] [MERGED] 13746 fix available ips API for posting custom-fields #14272

New Issue
Closed
opened 2025-12-29 23:23:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13889
Author: @arthanson
Created: 9/25/2023
Status: ✅ Merged
Merged: 10/5/2023
Merged by: @jeremystretch

Base: develop ← Head: 13746-available-ips-api

📝 Commits (3)

  • e0f17ce 13746 fix available ips API for posting custom-fields
  • 672a16b Merge branch 'develop' into 13746-available-ips-api
  • ee485fd Merge branch 'develop' into 13746-available-ips-api

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/ipam/api/views.py (+1 -1)

📄 Description

Fixes: #13746

Fixes AvailableObjectsView, previously the prep_object_data was using serializer.validated_data which stripped out many fields (such as custom fields). Changed to use requested_objects which will still have those fields. This data is just sent to the serializers so there is no reason to use the serializer vaildated_data as input.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13889 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 9/25/2023 **Status:** ✅ Merged **Merged:** 10/5/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13746-available-ips-api` --- ### 📝 Commits (3) - [`e0f17ce`](https://github.com/netbox-community/netbox/commit/e0f17cee0e5379c3850bf1d80214c80c6eba15ae) 13746 fix available ips API for posting custom-fields - [`672a16b`](https://github.com/netbox-community/netbox/commit/672a16b473fe67467ae5adb143ebda89f427d6f4) Merge branch 'develop' into 13746-available-ips-api - [`ee485fd`](https://github.com/netbox-community/netbox/commit/ee485fdb6505c97e33bdba7b02b9b617e0f2dec1) Merge branch 'develop' into 13746-available-ips-api ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/api/views.py` (+1 -1) </details> ### 📄 Description ### Fixes: #13746 Fixes AvailableObjectsView, previously the prep_object_data was using serializer.validated_data which stripped out many fields (such as custom fields). Changed to use requested_objects which will still have those fields. This data is just sent to the serializers so there is no reason to use the serializer vaildated_data as input. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:32 +01:00
adam closed this issue 2025-12-29 23:23:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?