starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13825] [MERGED] 13809 fix ConfigRevision edit if custom validators #14259

New Issue
Closed
opened 2025-12-29 23:23:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13825
Author: @arthanson
Created: 9/19/2023
Status: ✅ Merged
Merged: 9/20/2023
Merged by: @jeremystretch

Base: develop ← Head: 13809-config-revision-custom-validator

📝 Commits (3)

  • d414304 13809 fix ConfigRevision edit, check if custom validator JSON serializable
  • 4e930a8 13809 check json rendering for all fields
  • f625c0d Refactor field initialization logic to more cleanly handle statically configured values

📊 Changes

1 file changed (+26 additions, -14 deletions)

View changed files

📝 netbox/extras/forms/model_forms.py (+26 -14)

📄 Description

Fixes: #13809

Disables the CUSTOM_VALIDATORS field if field is not JSON serializable (because it uses custom functions).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13825 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 9/19/2023 **Status:** ✅ Merged **Merged:** 9/20/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13809-config-revision-custom-validator` --- ### 📝 Commits (3) - [`d414304`](https://github.com/netbox-community/netbox/commit/d414304168278f33959fff37f19ff25e0b4062f9) 13809 fix ConfigRevision edit, check if custom validator JSON serializable - [`4e930a8`](https://github.com/netbox-community/netbox/commit/4e930a80ed1eabbabf04cb72bb76d8677b6012f6) 13809 check json rendering for all fields - [`f625c0d`](https://github.com/netbox-community/netbox/commit/f625c0de49e72de939408654e5141ab6a2a64060) Refactor field initialization logic to more cleanly handle statically configured values ### 📊 Changes **1 file changed** (+26 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/forms/model_forms.py` (+26 -14) </details> ### 📄 Description ### Fixes: #13809 Disables the CUSTOM_VALIDATORS field if field is not JSON serializable (because it uses custom functions). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:27 +01:00
adam closed this issue 2025-12-29 23:23:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?