starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13826] [MERGED] Fixes #11617: Check for invalid CSV headers during bulk import #14256

New Issue
Closed
opened 2025-12-29 23:23:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13826
Author: @jeremystretch
Created: 9/19/2023
Status: ✅ Merged
Merged: 9/20/2023
Merged by: @jeremystretch

Base: develop ← Head: 11617-csv-headers-validation

📝 Commits (2)

  • 06cb140 Fixes #11617: Check for invalid CSV headers during bulk import
  • a64832a Add test for CSV import header validation

📊 Changes

3 files changed (+43 additions, -10 deletions)

View changed files

📝 netbox/netbox/tests/test_import.py (+30 -0)
📝 netbox/utilities/forms/bulk_import.py (+1 -0)
📝 netbox/utilities/forms/forms.py (+12 -10)

📄 Description

Fixes: #11617

This is being submitted as a lightweight alternative to PR #12013. I believe it resolves the root issue without significantly refactoring the bulk import logic.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13826 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/19/2023 **Status:** ✅ Merged **Merged:** 9/20/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11617-csv-headers-validation` --- ### 📝 Commits (2) - [`06cb140`](https://github.com/netbox-community/netbox/commit/06cb1400d008037689746682a264403f4b7de6d6) Fixes #11617: Check for invalid CSV headers during bulk import - [`a64832a`](https://github.com/netbox-community/netbox/commit/a64832ade33c33df378376af5f820fea55f3b679) Add test for CSV import header validation ### 📊 Changes **3 files changed** (+43 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/tests/test_import.py` (+30 -0) 📝 `netbox/utilities/forms/bulk_import.py` (+1 -0) 📝 `netbox/utilities/forms/forms.py` (+12 -10) </details> ### 📄 Description ### Fixes: #11617 This is being submitted as a lightweight alternative to PR #12013. I believe it resolves the root issue without significantly refactoring the bulk import logic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:27 +01:00
adam closed this issue 2025-12-29 23:23:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14256
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?