[PR #13753] [MERGED] Fixes #12219: Ensure dashboard widget heading text has sufficient contrast #14248

New Issue

adam · 2025-12-29T23:23:25+01:00

adam commented

2025-12-29 23:23:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13753
Author: @jeremystretch
Created: 9/13/2023
Status: ✅ Merged
Merged: 9/13/2023
Merged by: @jeremystretch

Base: develop ← Head: 12219-widget-colors

📝 Commits (2)

478bb2b Fixes #12219: Ensure dashboard widget heading text has sufficient contrast in both light & dark modes
712c893 Change foreground color for teal background

📊 Changes

2 files changed (+24 additions, -3 deletions)

View changed files

📝 netbox/extras/dashboard/widgets.py (+17 -0)
📝 netbox/templates/extras/dashboard/widget.html (+7 -3)

📄 Description

Fixes: #12219

Introduces the fg_color property on DashboardWidget to return white or black as appropriate given the assigned background color
Modifies the widget template to use that color for all heading elements

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13753 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/13/2023 **Status:** ✅ Merged **Merged:** 9/13/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12219-widget-colors` --- ### 📝 Commits (2) - [`478bb2b`](https://github.com/netbox-community/netbox/commit/478bb2b7dd9289d5ead15cf8752cf3ff6cfdc006) Fixes #12219: Ensure dashboard widget heading text has sufficient contrast in both light & dark modes - [`712c893`](https://github.com/netbox-community/netbox/commit/712c893a1566e184082fb5b7bb71b1928b48b57d) Change foreground color for teal background ### 📊 Changes **2 files changed** (+24 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/dashboard/widgets.py` (+17 -0) 📝 `netbox/templates/extras/dashboard/widget.html` (+7 -3) </details> ### 📄 Description ### Fixes: #12219 - Introduces the `fg_color` property on DashboardWidget to return white or black as appropriate given the assigned background color - Modifies the widget template to use that color for all heading elements ![dashboard_light](https://github.com/netbox-community/netbox/assets/13487278/c02d5033-f9ff-47cc-b48f-32f4f5728349) ![dashboard_dark](https://github.com/netbox-community/netbox/assets/13487278/f9ecf5c7-9120-40cf-bf41-edbca35198fa) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:23:25 +01:00

adam closed this issue

2025-12-29 23:23:25 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14248