starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13633] [MERGED] Fixes #13632: Avoid raising exception when checking if FHRP group IP address is primary #14230

New Issue
Closed
opened 2025-12-29 23:23:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13633
Author: @jeremystretch
Created: 8/31/2023
Status: ✅ Merged
Merged: 8/31/2023
Merged by: @jeremystretch

Base: develop ← Head: 13632-fhrpgroup-ip-fix

📝 Commits (1)

  • 49c2c01 Fixes #13632: Avoid raising exception when checking if FHRP group IP address is primary

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 netbox/ipam/models/ip.py (+3 -3)

📄 Description

Fixes: #13632

Check for presences of primary_ip4 and primary_ip6 attributes on parent object before attempting to evaluate them.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13633 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 8/31/2023 **Status:** ✅ Merged **Merged:** 8/31/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13632-fhrpgroup-ip-fix` --- ### 📝 Commits (1) - [`49c2c01`](https://github.com/netbox-community/netbox/commit/49c2c012729c8bee8062579fd44102c874596c6f) Fixes #13632: Avoid raising exception when checking if FHRP group IP address is primary ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/models/ip.py` (+3 -3) </details> ### 📄 Description ### Fixes: #13632 Check for presences of `primary_ip4` and `primary_ip6` attributes on parent object before attempting to evaluate them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:18 +01:00
adam closed this issue 2025-12-29 23:23:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?