starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13337] [MERGED] Fixes: #11079 - Handle cables across multiple rear-port positions #14165

New Issue
Closed
opened 2025-12-29 23:22:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13337
Author: @DanSheps
Created: 8/1/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @jeremystretch

Base: develop ← Head: 11079-Cablepath_catch_assertions

📝 Commits (10+)

  • 7c09eb2 Catch AssertionError's in signals. Handle accordingly
  • 32c4f3c Alter cable logic to handle certain additional path types.
  • a797995 Fix failures and add test
  • 7a15b2b More tests
  • 4cf5ac5 Remove not needed tests, add additional tests
  • 4fb67dd Finish tests, correct some behaviour
  • b335b67 Add check for mid-span device not allowed condition
  • 3ca03d3 Remove excess import
  • b32ecb5 Remove logging import
  • d2a851b Remove logging import

📊 Changes

4 files changed (+605 additions, -74 deletions)

View changed files

📝 netbox/dcim/models/cables.py (+91 -31)
📝 netbox/dcim/svg/cables.py (+109 -38)
📝 netbox/dcim/tests/test_cablepaths.py (+396 -4)
📝 netbox/templates/dcim/cable_trace.html (+9 -1)

📄 Description

Fixes: #11079 - Add supported path through modules and multiple rear-ports with different positions on same device

  • Add support for pathing through modules.
  • Adds some logic to generate split paths when path lengths vary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13337 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 8/1/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11079-Cablepath_catch_assertions` --- ### 📝 Commits (10+) - [`7c09eb2`](https://github.com/netbox-community/netbox/commit/7c09eb298ddf015eedf0454bd21b551ad1618bd2) Catch AssertionError's in signals. Handle accordingly - [`32c4f3c`](https://github.com/netbox-community/netbox/commit/32c4f3c8a6ab60727df10cbd36fb484bfb384045) Alter cable logic to handle certain additional path types. - [`a797995`](https://github.com/netbox-community/netbox/commit/a797995ebb72b0e35e41b65fe0445d7f36de9daa) Fix failures and add test - [`7a15b2b`](https://github.com/netbox-community/netbox/commit/7a15b2bce851f05bf10002435ce8c966188356b5) More tests - [`4cf5ac5`](https://github.com/netbox-community/netbox/commit/4cf5ac54de27ceb749990cc67b3b498899b347c8) Remove not needed tests, add additional tests - [`4fb67dd`](https://github.com/netbox-community/netbox/commit/4fb67dd6ae40e8eec6729162c23bb1cc5ea86e18) Finish tests, correct some behaviour - [`b335b67`](https://github.com/netbox-community/netbox/commit/b335b675caeeb30d3ae1d1a77a52417d95b4170b) Add check for mid-span device not allowed condition - [`3ca03d3`](https://github.com/netbox-community/netbox/commit/3ca03d3d891e278472c286feaf42421d45db9893) Remove excess import - [`b32ecb5`](https://github.com/netbox-community/netbox/commit/b32ecb50fb0a33faa73f994b1edaa8425ee7d76c) Remove logging import - [`d2a851b`](https://github.com/netbox-community/netbox/commit/d2a851b3bcf16556745ab95d55cee81799a0d77b) Remove logging import ### 📊 Changes **4 files changed** (+605 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/cables.py` (+91 -31) 📝 `netbox/dcim/svg/cables.py` (+109 -38) 📝 `netbox/dcim/tests/test_cablepaths.py` (+396 -4) 📝 `netbox/templates/dcim/cable_trace.html` (+9 -1) </details> ### 📄 Description ### Fixes: #11079 - Add supported path through modules and multiple rear-ports with different positions on same device * Add support for pathing through modules. * Adds some logic to generate split paths when path lengths vary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:57 +01:00
adam closed this issue 2025-12-29 23:22:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?