starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13296] [MERGED] Fix #11478 - Add vc_interfaces flag to control selection of VC interfaces #14147

New Issue
Closed
opened 2025-12-29 23:22:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13296
Author: @DanSheps
Created: 7/28/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @jeremystretch

Base: feature ← Head: 11478-fix-cabling-interface-display

📝 Commits (10+)

  • 2b8284c Add vc_interfaces flag to control interface queryset
  • 1f01dbc Fix test failure
  • e35d658 Merge branch '11478-fix-cabling-interface-display' of https://github.com/netbox-community/netbox into 11478-fix-cabling-interface-display
  • a91c096 Add new filters instead of using undocumented query params
  • e439a57 Cleanup filterset, add test
  • 5dba592 Rename filter and re-introduce virtual_chassis filtering method (required)
  • ef9b002 Fix test
  • 245fd2e Adjust tests to more accurately provide coverage
  • aceceba Add breaking change note
  • e9ec4b9 Merge branch 'feature' into 11478-fix-cabling-interface-display

📊 Changes

4 files changed (+96 additions, -52 deletions)

View changed files

📝 docs/release-notes/version-3.6.md (+1 -0)
📝 netbox/dcim/filtersets.py (+9 -23)
📝 netbox/dcim/forms/model_forms.py (+3 -3)
📝 netbox/dcim/tests/test_filtersets.py (+83 -26)

📄 Description

Fixes: #11478 - Add vc_interfaces flag to control selection of VC interfaces

  • Create a vc_interfaces flag that can be used for controlling device queryset generation.
  • Update interface edit form to account for new flag

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13296 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 7/28/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `11478-fix-cabling-interface-display` --- ### 📝 Commits (10+) - [`2b8284c`](https://github.com/netbox-community/netbox/commit/2b8284cb06352a055f8b36ad115e2066f4af5e9b) Add `vc_interfaces` flag to control interface queryset - [`1f01dbc`](https://github.com/netbox-community/netbox/commit/1f01dbc0e6e48412176c56dd78d24422a0bd7bd1) Fix test failure - [`e35d658`](https://github.com/netbox-community/netbox/commit/e35d658d74fbcbe5c1eee47dc5530b530dfbe008) Merge branch '11478-fix-cabling-interface-display' of https://github.com/netbox-community/netbox into 11478-fix-cabling-interface-display - [`a91c096`](https://github.com/netbox-community/netbox/commit/a91c0961011e6a1a505062a15a9f1786b97303f4) Add new filters instead of using undocumented query params - [`e439a57`](https://github.com/netbox-community/netbox/commit/e439a57e28078e13db59aa32dbe4b75a8219c59d) Cleanup filterset, add test - [`5dba592`](https://github.com/netbox-community/netbox/commit/5dba5926585eb9aee4e962a44015203519388ef8) Rename filter and re-introduce virtual_chassis filtering method (required) - [`ef9b002`](https://github.com/netbox-community/netbox/commit/ef9b002f4468c1aeecdc2d4390e4a49b585995bd) Fix test - [`245fd2e`](https://github.com/netbox-community/netbox/commit/245fd2e7006581ca6df7f7647bf2da5b2b034e7c) Adjust tests to more accurately provide coverage - [`aceceba`](https://github.com/netbox-community/netbox/commit/aceceba4a58389687c4e29db9a149b50dba1a3f7) Add breaking change note - [`e9ec4b9`](https://github.com/netbox-community/netbox/commit/e9ec4b964459eea6f1f75a4e1c09b7bbcaa9db82) Merge branch 'feature' into 11478-fix-cabling-interface-display ### 📊 Changes **4 files changed** (+96 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-3.6.md` (+1 -0) 📝 `netbox/dcim/filtersets.py` (+9 -23) 📝 `netbox/dcim/forms/model_forms.py` (+3 -3) 📝 `netbox/dcim/tests/test_filtersets.py` (+83 -26) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #11478 - Add vc_interfaces flag to control selection of VC interfaces * Create a `vc_interfaces` flag that can be used for controlling device queryset generation. * Update interface edit form to account for new flag --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:48 +01:00
adam closed this issue 2025-12-29 23:22:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14147
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?