starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13174] [MERGED] 13149 add gettext_lazy to form fields #14129

New Issue
Closed
opened 2025-12-29 23:22:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13174
Author: @arthanson
Created: 7/13/2023
Status: ✅ Merged
Merged: 7/31/2023
Merged by: @jeremystretch

Base: feature ← Head: 13149-form-gettext

📝 Commits (10+)

  • 6f0b7fa 13149 add gettext_lazy to forms
  • 5f5b332 13149 add gettext_lazy to forms
  • 05cab09 13149 add gettext_lazy to forms
  • e9c553b 13149 add gettext_lazy to forms
  • 546f6d0 13149 add gettext_lazy to forms
  • 3caa69b 13149 add gettext_lazy to forms
  • f849a63 13149 add gettext_lazy to forms
  • 7fb81a0 13149 add gettext_lazy to forms
  • b6e50b7 13149 add gettext_lazy to forms
  • 887dfa0 13149 add gettext_lazy to forms

📊 Changes

51 files changed (+1381 additions, -601 deletions)

View changed files

📝 netbox/circuits/forms/bulk_edit.py (+22 -16)
📝 netbox/circuits/forms/bulk_import.py (+10 -1)
📝 netbox/circuits/forms/filtersets.py (+15 -10)
📝 netbox/circuits/forms/model_forms.py (+14 -7)
📝 netbox/core/forms/bulk_edit.py (+6 -4)
📝 netbox/core/forms/filtersets.py (+17 -5)
📝 netbox/core/forms/mixins.py (+1 -1)
📝 netbox/core/forms/model_forms.py (+5 -4)
📝 netbox/dcim/forms/bulk_create.py (+3 -1)
📝 netbox/dcim/forms/bulk_edit.py (+197 -60)
📝 netbox/dcim/forms/bulk_import.py (+119 -2)
📝 netbox/dcim/forms/common.py (+15 -8)
📝 netbox/dcim/forms/connections.py (+1 -1)
📝 netbox/dcim/forms/filtersets.py (+194 -129)
📝 netbox/dcim/forms/formsets.py (+4 -1)
📝 netbox/dcim/forms/model_forms.py (+101 -43)
📝 netbox/dcim/forms/object_create.py (+19 -7)
📝 netbox/dcim/forms/object_import.py (+9 -1)
📝 netbox/extras/forms/bulk_edit.py (+33 -1)
📝 netbox/extras/forms/bulk_import.py (+11 -1)

...and 31 more files

📄 Description

Fixes: #13149

Makes sure all form fields have localizable label, also converts all formset titles to use gettext_lazy.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13174 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 7/13/2023 **Status:** ✅ Merged **Merged:** 7/31/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `13149-form-gettext` --- ### 📝 Commits (10+) - [`6f0b7fa`](https://github.com/netbox-community/netbox/commit/6f0b7fa1337c2c1508682a7123d3666a7e90f3d7) 13149 add gettext_lazy to forms - [`5f5b332`](https://github.com/netbox-community/netbox/commit/5f5b332a653a6f18701c08b1949bbe0dfca0cea2) 13149 add gettext_lazy to forms - [`05cab09`](https://github.com/netbox-community/netbox/commit/05cab09e30b7529a056fdc232016fb9983cf8f21) 13149 add gettext_lazy to forms - [`e9c553b`](https://github.com/netbox-community/netbox/commit/e9c553bb7b6f32577797c99c20c60ff758e1856b) 13149 add gettext_lazy to forms - [`546f6d0`](https://github.com/netbox-community/netbox/commit/546f6d0316bfd01b3f439d5d9461c1680c88678c) 13149 add gettext_lazy to forms - [`3caa69b`](https://github.com/netbox-community/netbox/commit/3caa69b8151a2991702a9dbf37850e8eeb7a40fc) 13149 add gettext_lazy to forms - [`f849a63`](https://github.com/netbox-community/netbox/commit/f849a63401f3f30d07a5f718762354a2db074308) 13149 add gettext_lazy to forms - [`7fb81a0`](https://github.com/netbox-community/netbox/commit/7fb81a0b4cc68aff293944cd6599e5715324bc6d) 13149 add gettext_lazy to forms - [`b6e50b7`](https://github.com/netbox-community/netbox/commit/b6e50b789c69ab36bdb4891da44b2bd1aa21ee6c) 13149 add gettext_lazy to forms - [`887dfa0`](https://github.com/netbox-community/netbox/commit/887dfa0234e245effb3ea4e89a1f672eb1e35ecc) 13149 add gettext_lazy to forms ### 📊 Changes **51 files changed** (+1381 additions, -601 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms/bulk_edit.py` (+22 -16) 📝 `netbox/circuits/forms/bulk_import.py` (+10 -1) 📝 `netbox/circuits/forms/filtersets.py` (+15 -10) 📝 `netbox/circuits/forms/model_forms.py` (+14 -7) 📝 `netbox/core/forms/bulk_edit.py` (+6 -4) 📝 `netbox/core/forms/filtersets.py` (+17 -5) 📝 `netbox/core/forms/mixins.py` (+1 -1) 📝 `netbox/core/forms/model_forms.py` (+5 -4) 📝 `netbox/dcim/forms/bulk_create.py` (+3 -1) 📝 `netbox/dcim/forms/bulk_edit.py` (+197 -60) 📝 `netbox/dcim/forms/bulk_import.py` (+119 -2) 📝 `netbox/dcim/forms/common.py` (+15 -8) 📝 `netbox/dcim/forms/connections.py` (+1 -1) 📝 `netbox/dcim/forms/filtersets.py` (+194 -129) 📝 `netbox/dcim/forms/formsets.py` (+4 -1) 📝 `netbox/dcim/forms/model_forms.py` (+101 -43) 📝 `netbox/dcim/forms/object_create.py` (+19 -7) 📝 `netbox/dcim/forms/object_import.py` (+9 -1) 📝 `netbox/extras/forms/bulk_edit.py` (+33 -1) 📝 `netbox/extras/forms/bulk_import.py` (+11 -1) _...and 31 more files_ </details> ### 📄 Description ### Fixes: #13149 Makes sure all form fields have localizable label, also converts all formset titles to use gettext_lazy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:42 +01:00
adam closed this issue 2025-12-29 23:22:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?