starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #13148] [MERGED] 13132 updated model fields to use gettext_lazy #14121

New Issue
Closed
opened 2025-12-29 23:22:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13148
Author: @arthanson
Created: 7/11/2023
Status: ✅ Merged
Merged: 7/31/2023
Merged by: @jeremystretch

Base: feature ← Head: 13132-model-gettext

📝 Commits (10+)

  • 2eb2703 13132 add gettext_lazy to models
  • 54c6101 13132 add gettext_lazy to models
  • 1195efc 13132 add gettext_lazy to models
  • 8b4b331 13132 add gettext_lazy to models
  • 9f2ae5f 13132 add gettext_lazy to models
  • 90c9e71 13132 add gettext_lazy to models
  • d051494 13132 add gettext_lazy to models
  • 4c2f8b6 13132 add gettext_lazy to models
  • bc39ab2 13132 add gettext_lazy to models
  • 2811915 Correct missed merge conflict

📊 Changes

36 files changed (+899 additions, -431 deletions)

View changed files

📝 netbox/circuits/models/circuits.py (+16 -14)
📝 netbox/circuits/models/providers.py (+8 -4)
📝 netbox/core/models/data.py (+14 -2)
📝 netbox/core/models/files.py (+5 -1)
📝 netbox/core/models/jobs.py (+10 -1)
📝 netbox/dcim/models/cables.py (+12 -1)
📝 netbox/dcim/models/device_component_templates.py (+45 -26)
📝 netbox/dcim/models/device_components.py (+145 -80)
📝 netbox/dcim/models/devices.py (+110 -59)
📝 netbox/dcim/models/mixins.py (+4 -1)
📝 netbox/dcim/models/power.py (+15 -4)
📝 netbox/dcim/models/racks.py (+28 -18)
📝 netbox/dcim/models/sites.py (+24 -13)
📝 netbox/extras/models/change_logging.py (+7 -0)
📝 netbox/extras/models/configs.py (+11 -3)
📝 netbox/extras/models/customfields.py (+84 -49)
📝 netbox/extras/models/dashboard.py (+3 -0)
📝 netbox/extras/models/models.py (+91 -37)
📝 netbox/extras/models/search.py (+8 -1)
📝 netbox/extras/models/staging.py (+5 -0)

...and 16 more files

📄 Description

Fixes: #13132

update model fields to make sure they have verbose_names on the fields that are localized via gettext_lazy, also audit / update help text and validation messages to make sure they are put in gettext_lazy as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13148 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 7/11/2023 **Status:** ✅ Merged **Merged:** 7/31/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `13132-model-gettext` --- ### 📝 Commits (10+) - [`2eb2703`](https://github.com/netbox-community/netbox/commit/2eb27032191195705728447d3b3582a95ce49584) 13132 add gettext_lazy to models - [`54c6101`](https://github.com/netbox-community/netbox/commit/54c610130ce367a92549162ebd49de458b3c19b5) 13132 add gettext_lazy to models - [`1195efc`](https://github.com/netbox-community/netbox/commit/1195efc2d12cfd121b53ab041e89b369861aad92) 13132 add gettext_lazy to models - [`8b4b331`](https://github.com/netbox-community/netbox/commit/8b4b331ffd1a0f7ae4afd439418f11da994bb3e0) 13132 add gettext_lazy to models - [`9f2ae5f`](https://github.com/netbox-community/netbox/commit/9f2ae5ffb2c1553f762a442ca526474a8eb4d962) 13132 add gettext_lazy to models - [`90c9e71`](https://github.com/netbox-community/netbox/commit/90c9e7168281f1d36fbfb676adbe20c2a55d6b62) 13132 add gettext_lazy to models - [`d051494`](https://github.com/netbox-community/netbox/commit/d051494cefbdd119e0ee6e91b785fd5241ef9520) 13132 add gettext_lazy to models - [`4c2f8b6`](https://github.com/netbox-community/netbox/commit/4c2f8b66cb44e71af079428200b954f1781ad7ec) 13132 add gettext_lazy to models - [`bc39ab2`](https://github.com/netbox-community/netbox/commit/bc39ab2c912a17347e29b6722008f2534d8f6977) 13132 add gettext_lazy to models - [`2811915`](https://github.com/netbox-community/netbox/commit/28119157e48cf27204c47de6e76aa67b50175a65) Correct missed merge conflict ### 📊 Changes **36 files changed** (+899 additions, -431 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/models/circuits.py` (+16 -14) 📝 `netbox/circuits/models/providers.py` (+8 -4) 📝 `netbox/core/models/data.py` (+14 -2) 📝 `netbox/core/models/files.py` (+5 -1) 📝 `netbox/core/models/jobs.py` (+10 -1) 📝 `netbox/dcim/models/cables.py` (+12 -1) 📝 `netbox/dcim/models/device_component_templates.py` (+45 -26) 📝 `netbox/dcim/models/device_components.py` (+145 -80) 📝 `netbox/dcim/models/devices.py` (+110 -59) 📝 `netbox/dcim/models/mixins.py` (+4 -1) 📝 `netbox/dcim/models/power.py` (+15 -4) 📝 `netbox/dcim/models/racks.py` (+28 -18) 📝 `netbox/dcim/models/sites.py` (+24 -13) 📝 `netbox/extras/models/change_logging.py` (+7 -0) 📝 `netbox/extras/models/configs.py` (+11 -3) 📝 `netbox/extras/models/customfields.py` (+84 -49) 📝 `netbox/extras/models/dashboard.py` (+3 -0) 📝 `netbox/extras/models/models.py` (+91 -37) 📝 `netbox/extras/models/search.py` (+8 -1) 📝 `netbox/extras/models/staging.py` (+5 -0) _...and 16 more files_ </details> ### 📄 Description ### Fixes: #13132 update model fields to make sure they have verbose_names on the fields that are localized via gettext_lazy, also audit / update help text and validation messages to make sure they are put in gettext_lazy as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:38 +01:00
adam closed this issue 2025-12-29 23:22:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?