starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12904] [MERGED] 12591 config params admin #14067

New Issue
Closed
opened 2025-12-29 23:22:19 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12904
Author: @arthanson
Created: 6/14/2023
Status: ✅ Merged
Merged: 6/22/2023
Merged by: @jeremystretch

Base: feature ← Head: 12591-config-params-admin

📝 Commits (10+)

📊 Changes

16 files changed (+567 additions, -252 deletions)

View changed files

📝 netbox/extras/admin.py (+1 -128)
📝 netbox/extras/filtersets.py (+25 -0)
📝 netbox/extras/forms/__init__.py (+0 -1)
➖ netbox/extras/forms/config.py (+0 -82)
📝 netbox/extras/forms/filtersets.py (+7 -0)
📝 netbox/extras/forms/model_forms.py (+101 -1)
➕ netbox/extras/migrations/0093_configrevision_ordering.py (+17 -0)
📝 netbox/extras/models/models.py (+8 -0)
📝 netbox/extras/tables/tables.py (+24 -0)
📝 netbox/extras/urls.py (+8 -1)
📝 netbox/extras/views.py (+69 -0)
📝 netbox/netbox/navigation/menu.py (+17 -0)
➖ netbox/templates/admin/extras/configrevision/restore.html (+0 -37)
➕ netbox/templates/extras/configrevision.html (+200 -0)
➕ netbox/templates/extras/configrevision_restore.html (+88 -0)
📝 netbox/templates/generic/object.html (+2 -2)

📄 Description

Fixes: #12591

Adds standard list, add, edit views for ConfigRevisions so can mange them within NetBox UI instead of the admin. Did not add the bulk edit or import views as those did not seem to make any sense for ConfigRevision. Left the functionality within the Admin, not sure if we wanted to remove those right away.

Note: Kept in the one-line admin.py as without it will cause a circular import issue. Opened up #12919 to track as this would require more refactoring that is worth a separate ticket.

Monosnap Config Revisions | NetBox 2023-06-14 12-44-20
Monosnap Editing config revision Config revision #1 (2023-06-13 22:21:04 520611+00:00) | NetBox 2023-06-14 12-44-37
Monosnap Restore: Config revision #3 (2023-06-16 15:18:54 162509+00:00) | NetBox 2023-06-16 13-10-51

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12904 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/14/2023 **Status:** ✅ Merged **Merged:** 6/22/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `12591-config-params-admin` --- ### 📝 Commits (10+) - [`fd6c6ba`](https://github.com/netbox-community/netbox/commit/fd6c6ba70e6b7c5f8db98b2e36a4786bf4d5d242) 12591 initial commit - [`c763e44`](https://github.com/netbox-community/netbox/commit/c763e4472c9a759fe4e943cb34c882038b194959) 12591 detail view - [`f93702f`](https://github.com/netbox-community/netbox/commit/f93702f0a19c9a2cc7bff0d99edf8488049af582) 12591 add/edit view - [`69b7fb7`](https://github.com/netbox-community/netbox/commit/69b7fb723d547103f7fc5e6edebbd5995a4d903e) 12591 edit button - [`718293d`](https://github.com/netbox-community/netbox/commit/718293d0b30df099f745176fc8b19d468b0aa67e) 12591 base views and forms - [`a1dd3c4`](https://github.com/netbox-community/netbox/commit/a1dd3c4381b4733fc5803d3ab919806815aea16d) 12591 form cleanup - [`6da65e0`](https://github.com/netbox-community/netbox/commit/6da65e0763b26d339690b43705b4879b487407c5) 12591 form cleanup - [`7ca0712`](https://github.com/netbox-community/netbox/commit/7ca0712b0fb6ee188f9cd008708631bd822a2c62) 12591 form cleanup - [`c6391bf`](https://github.com/netbox-community/netbox/commit/c6391bfb5befe61bb9a0ed9ea45c3a5a73936aad) 12591 review changes - [`03705a3`](https://github.com/netbox-community/netbox/commit/03705a3e61539b873b563879c8f76a6ef8101dff) Merge branch 'feature' into 12591-config-params-admin ### 📊 Changes **16 files changed** (+567 additions, -252 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/admin.py` (+1 -128) 📝 `netbox/extras/filtersets.py` (+25 -0) 📝 `netbox/extras/forms/__init__.py` (+0 -1) ➖ `netbox/extras/forms/config.py` (+0 -82) 📝 `netbox/extras/forms/filtersets.py` (+7 -0) 📝 `netbox/extras/forms/model_forms.py` (+101 -1) ➕ `netbox/extras/migrations/0093_configrevision_ordering.py` (+17 -0) 📝 `netbox/extras/models/models.py` (+8 -0) 📝 `netbox/extras/tables/tables.py` (+24 -0) 📝 `netbox/extras/urls.py` (+8 -1) 📝 `netbox/extras/views.py` (+69 -0) 📝 `netbox/netbox/navigation/menu.py` (+17 -0) ➖ `netbox/templates/admin/extras/configrevision/restore.html` (+0 -37) ➕ `netbox/templates/extras/configrevision.html` (+200 -0) ➕ `netbox/templates/extras/configrevision_restore.html` (+88 -0) 📝 `netbox/templates/generic/object.html` (+2 -2) </details> ### 📄 Description ### Fixes: #12591 Adds standard list, add, edit views for ConfigRevisions so can mange them within NetBox UI instead of the admin. Did not add the bulk edit or import views as those did not seem to make any sense for ConfigRevision. Left the functionality within the Admin, not sure if we wanted to remove those right away. **Note:** Kept in the one-line admin.py as without it will cause a circular import issue. Opened up #12919 to track as this would require more refactoring that is worth a separate ticket. ![Monosnap Config Revisions | NetBox 2023-06-14 12-44-20](https://github.com/netbox-community/netbox/assets/99642/820569cf-e9f7-42e2-952f-1834c9ae423b) ![Monosnap Editing config revision Config revision #1 (2023-06-13 22:21:04 520611+00:00) | NetBox 2023-06-14 12-44-37](https://github.com/netbox-community/netbox/assets/99642/17d27c24-48ad-4c77-994b-72c46c4d6d9b) ![Monosnap Restore: Config revision #3 (2023-06-16 15:18:54 162509+00:00) | NetBox 2023-06-16 13-10-51](https://github.com/netbox-community/netbox/assets/99642/847c2fea-0607-4da0-a641-3acc5976f17e) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:19 +01:00
adam closed this issue 2025-12-29 23:22:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?