starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12877] [MERGED] 12589 move user and group admin from admin #14060

New Issue
Closed
opened 2025-12-29 23:22:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12877
Author: @arthanson
Created: 6/13/2023
Status: ✅ Merged
Merged: 7/20/2023
Merged by: @jeremystretch

Base: feature ← Head: 12589-user-admin

📝 Commits (10+)

  • 773a4f9 125890 first working user list
  • b17dfa0 125890 first working user list
  • a609467 125890 add form fields
  • bd67cfb 125890 basic group objectpermission views
  • 4da0b83 125890 basic group objectpermission views
  • 2fdd834 125890 fix group permission views
  • f1eadc6 125890 fix objectpermission form
  • 4560eb6 125890 fixes
  • 30a168a 125890 fixes
  • 057fbf0 12589 fix boolean filters

📊 Changes

32 files changed (+1545 additions, -421 deletions)

View changed files

📝 netbox/netbox/navigation/menu.py (+51 -0)
📝 netbox/netbox/views/generic/mixins.py (+1 -0)
📝 netbox/templates/users/account/api_token.html (+0 -0)
📝 netbox/templates/users/account/api_tokens.html (+1 -1)
📝 netbox/templates/users/account/base.html (+6 -5)
📝 netbox/templates/users/account/bookmarks.html (+1 -1)
📝 netbox/templates/users/account/password.html (+1 -1)
📝 netbox/templates/users/account/preferences.html (+1 -1)
📝 netbox/templates/users/account/profile.html (+1 -1)
➕ netbox/templates/users/group.html (+48 -0)
➕ netbox/templates/users/objectpermission.html (+97 -0)
➕ netbox/templates/users/user.html (+84 -0)
📝 netbox/users/admin/__init__.py (+0 -98)
📝 netbox/users/admin/forms.py (+1 -116)
📝 netbox/users/filtersets.py (+20 -1)
➖ netbox/users/forms.py (+0 -130)
➕ netbox/users/forms/__init__.py (+5 -0)
➕ netbox/users/forms/authentication.py (+25 -0)
➕ netbox/users/forms/bulk_edit.py (+72 -0)
➕ netbox/users/forms/bulk_import.py (+32 -0)

...and 12 more files

📄 Description

Fixes: #12589

Moves user, groups and permissions pages from admin to NetBox UI.

Removed some bulk editing / bulk import as it didn't make sense or was a potential security issue. For example, the only thing you can set on a group is a name so it doesn't make sense to have bulk editing for it. Also didn't think we wanted to do bulk import for users as that would need a file with passwords in it.

Had to change some tests as the permission opt-out was special case to always apply for the user and group objects.

These have permission checks but wondering if we want to make some of them superuser only (ObjectPermission, Change Password, Edit User)? Will probably want some tweaks after discussing, but all the core functionality is there.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12877 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/13/2023 **Status:** ✅ Merged **Merged:** 7/20/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `12589-user-admin` --- ### 📝 Commits (10+) - [`773a4f9`](https://github.com/netbox-community/netbox/commit/773a4f9896b540a5dfd27798714761f31db53a99) 125890 first working user list - [`b17dfa0`](https://github.com/netbox-community/netbox/commit/b17dfa05345fce3505aa928a748bc8897d618023) 125890 first working user list - [`a609467`](https://github.com/netbox-community/netbox/commit/a6094679683629ac209929c8bb8994836614ef9a) 125890 add form fields - [`bd67cfb`](https://github.com/netbox-community/netbox/commit/bd67cfb4014bd96cf297e830eff4d71dbf36735b) 125890 basic group objectpermission views - [`4da0b83`](https://github.com/netbox-community/netbox/commit/4da0b835fdd1461baa1f3811e34d192e2b55f0fe) 125890 basic group objectpermission views - [`2fdd834`](https://github.com/netbox-community/netbox/commit/2fdd834a6601c9c5b3496427fa31e7a2136b3631) 125890 fix group permission views - [`f1eadc6`](https://github.com/netbox-community/netbox/commit/f1eadc6a5c15d5e718d35b16037f94cab75692db) 125890 fix objectpermission form - [`4560eb6`](https://github.com/netbox-community/netbox/commit/4560eb650856842ce5c9563bdf409278f7232f05) 125890 fixes - [`30a168a`](https://github.com/netbox-community/netbox/commit/30a168a33e1f19c8fdf87818c65b3e898454ec89) 125890 fixes - [`057fbf0`](https://github.com/netbox-community/netbox/commit/057fbf0ac4bd0e240a5ee4792f9b0a844612704a) 12589 fix boolean filters ### 📊 Changes **32 files changed** (+1545 additions, -421 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/navigation/menu.py` (+51 -0) 📝 `netbox/netbox/views/generic/mixins.py` (+1 -0) 📝 `netbox/templates/users/account/api_token.html` (+0 -0) 📝 `netbox/templates/users/account/api_tokens.html` (+1 -1) 📝 `netbox/templates/users/account/base.html` (+6 -5) 📝 `netbox/templates/users/account/bookmarks.html` (+1 -1) 📝 `netbox/templates/users/account/password.html` (+1 -1) 📝 `netbox/templates/users/account/preferences.html` (+1 -1) 📝 `netbox/templates/users/account/profile.html` (+1 -1) ➕ `netbox/templates/users/group.html` (+48 -0) ➕ `netbox/templates/users/objectpermission.html` (+97 -0) ➕ `netbox/templates/users/user.html` (+84 -0) 📝 `netbox/users/admin/__init__.py` (+0 -98) 📝 `netbox/users/admin/forms.py` (+1 -116) 📝 `netbox/users/filtersets.py` (+20 -1) ➖ `netbox/users/forms.py` (+0 -130) ➕ `netbox/users/forms/__init__.py` (+5 -0) ➕ `netbox/users/forms/authentication.py` (+25 -0) ➕ `netbox/users/forms/bulk_edit.py` (+72 -0) ➕ `netbox/users/forms/bulk_import.py` (+32 -0) _...and 12 more files_ </details> ### 📄 Description ### Fixes: #12589 Moves user, groups and permissions pages from admin to NetBox UI. Removed some bulk editing / bulk import as it didn't make sense or was a potential security issue. For example, the only thing you can set on a group is a name so it doesn't make sense to have bulk editing for it. Also didn't think we wanted to do bulk import for users as that would need a file with passwords in it. Had to change some tests as the permission opt-out was special case to always apply for the user and group objects. These have permission checks but wondering if we want to make some of them superuser only (ObjectPermission, Change Password, Edit User)? Will probably want some tweaks after discussing, but all the core functionality is there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:17 +01:00
adam closed this issue 2025-12-29 23:22:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?