starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12820] [MERGED] Fixes #11209 - Fix PrefixIPAddress view with saved sort preferences #14051

New Issue
Closed
opened 2025-12-29 23:22:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12820
Author: @DanSheps
Created: 6/6/2023
Status: ✅ Merged
Merged: 9/13/2023
Merged by: @jeremystretch

Base: develop ← Head: 11209-fix-prefix-ipaddress-list-sorting

📝 Commits (4)

  • 42428c4 Fixes #11209 - Do not add available ips when IPAddressTable sort preferences are saved
  • 16c253b Refine check to account scenario right after clearing ordering string
  • 70e1802 Introduce get_table_ordering() utility to determine intended ordering given a request
  • eb89d2b Apply fix to VLAN ranges as well

📊 Changes

2 files changed (+21 additions, -3 deletions)

View changed files

📝 netbox/ipam/views.py (+5 -3)
📝 netbox/utilities/tables.py (+16 -0)

📄 Description

Fixes: #11209 - Do not add available ips when IPAddressTable sort preferences are saved

  • Exclude the IPAddress ViewTab from adding available IP annotations when table is sorted.

Checked other views (PrefixPrefixes, PrefixIPRanges) for this and is only present in the IPAddress view (Prefixes are annotated with actual prefixes, IPRanges have no such annotation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12820 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 6/6/2023 **Status:** ✅ Merged **Merged:** 9/13/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11209-fix-prefix-ipaddress-list-sorting` --- ### 📝 Commits (4) - [`42428c4`](https://github.com/netbox-community/netbox/commit/42428c4e058dcdecfc5a06de9ea3a570f52fcacf) Fixes #11209 - Do not add available ips when IPAddressTable sort preferences are saved - [`16c253b`](https://github.com/netbox-community/netbox/commit/16c253b2da217ce7c32d367d4e6f0c343ae2b498) Refine check to account scenario right after clearing ordering string - [`70e1802`](https://github.com/netbox-community/netbox/commit/70e18021d1db17ba84244d5db6ee346c8b527db2) Introduce get_table_ordering() utility to determine intended ordering given a request - [`eb89d2b`](https://github.com/netbox-community/netbox/commit/eb89d2b2b88ed5f0d21cdce172ff1a2b607fdf7c) Apply fix to VLAN ranges as well ### 📊 Changes **2 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/views.py` (+5 -3) 📝 `netbox/utilities/tables.py` (+16 -0) </details> ### 📄 Description ### Fixes: #11209 - Do not add available ips when IPAddressTable sort preferences are saved * Exclude the IPAddress ViewTab from adding available IP annotations when table is sorted. Checked other views (PrefixPrefixes, PrefixIPRanges) for this and is only present in the IPAddress view (Prefixes are annotated with actual prefixes, IPRanges have no such annotation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:14 +01:00
adam closed this issue 2025-12-29 23:22:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?