starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12755] [MERGED] Fixes #12745 - Escape text passed as display values to slim-select #14041

New Issue
Closed
opened 2025-12-29 23:22:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:22:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12755
Author: @kkthxbye-code
Created: 5/30/2023
Status: ✅ Merged
Merged: 5/30/2023
Merged by: @jeremystretch

Base: develop ← Head: 12745-escape-slim-select-html

📝 Commits (1)

  • e4d34fc Escape text passed as display values to slim-select

📊 Changes

5 files changed (+26 additions, -18 deletions)

View changed files

📝 netbox/project-static/dist/netbox.js (+15 -14)
📝 netbox/project-static/dist/netbox.js.map (+2 -2)
📝 netbox/project-static/package.json (+1 -0)
📝 netbox/project-static/src/select/api/apiSelect.ts (+3 -2)
📝 netbox/project-static/yarn.lock (+5 -0)

📄 Description

Fixes: #12745

Adds js dependencies html-entities (yes, there really is no built-in method for this is js) and escapes display text passed to slim-select.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12755 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 5/30/2023 **Status:** ✅ Merged **Merged:** 5/30/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12745-escape-slim-select-html` --- ### 📝 Commits (1) - [`e4d34fc`](https://github.com/netbox-community/netbox/commit/e4d34fc3b8975b4d43d952a96754fe3504662aae) Escape text passed as display values to slim-select ### 📊 Changes **5 files changed** (+26 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.js` (+15 -14) 📝 `netbox/project-static/dist/netbox.js.map` (+2 -2) 📝 `netbox/project-static/package.json` (+1 -0) 📝 `netbox/project-static/src/select/api/apiSelect.ts` (+3 -2) 📝 `netbox/project-static/yarn.lock` (+5 -0) </details> ### 📄 Description ### Fixes: #12745 Adds js dependencies html-entities (yes, there really is no built-in method for this is js) and escapes display text passed to slim-select. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:22:12 +01:00
adam closed this issue 2025-12-29 23:22:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?