starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12491] [MERGED] 12489 Use HTMX for Location and Non-Racked Devices in Site detail view #13990

New Issue
Closed
opened 2025-12-29 23:21:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12491
Author: @arthanson
Created: 5/4/2023
Status: ✅ Merged
Merged: 8/28/2023
Merged by: @jeremystretch

Base: develop ← Head: 12489-site-locations

📝 Commits (10+)

  • 68874f2 12489 use htmx for site view locations and non-racked-devices
  • 054e3c1 12489 remove now unused queries in context
  • 20ad552 adds device type and role to device component filter #12015
  • 0a6c630 Revert "Fixes #12463: Fix the association of completed jobs with reports & scripts in the REST API"
  • 73e20ef 12489 update nonracked_devices on rack and location templates
  • e1b342e 12489 fix whitespace issue
  • cb3fa5f Undo errant commits
  • 77737b5 12489 update site id in templates
  • 183a7ae Merge branch 'develop' into 12489-site-locations
  • 816cee5 12489 remove nonracked_devices include

📊 Changes

4 files changed (+49 additions, -153 deletions)

View changed files

📝 netbox/dcim/views.py (+0 -32)
➖ netbox/templates/dcim/inc/nonracked_devices.html (+0 -76)
📝 netbox/templates/dcim/location.html (+21 -1)
📝 netbox/templates/dcim/site.html (+28 -44)

📄 Description

Fixes: #12489

Changes site view to use HTMX for Locations and Non-Racked Devices in Site detail view. See before and after screenshots below. Also removed the now unused queries from the view.

Monosnap MDF | NetBox 2023-05-04 14-39-25
Monosnap MDF | NetBox 2023-05-04 14-39-56

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12491 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/4/2023 **Status:** ✅ Merged **Merged:** 8/28/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12489-site-locations` --- ### 📝 Commits (10+) - [`68874f2`](https://github.com/netbox-community/netbox/commit/68874f249d144c453de1d76c7faa163c9bfdd0f1) 12489 use htmx for site view locations and non-racked-devices - [`054e3c1`](https://github.com/netbox-community/netbox/commit/054e3c119bb242c43c35c44c01cc789a4f158665) 12489 remove now unused queries in context - [`20ad552`](https://github.com/netbox-community/netbox/commit/20ad5526c6558a9206f604d79e3ebdaac24dacad) adds device type and role to device component filter #12015 - [`0a6c630`](https://github.com/netbox-community/netbox/commit/0a6c630d74da2ed0d7c7ace6520928f2e5a59162) Revert "Fixes #12463: Fix the association of completed jobs with reports & scripts in the REST API" - [`73e20ef`](https://github.com/netbox-community/netbox/commit/73e20ef11b664326ffd702b6a965df86c36b6cce) 12489 update nonracked_devices on rack and location templates - [`e1b342e`](https://github.com/netbox-community/netbox/commit/e1b342e35675a47e0e7278c66a1dbe848a4d1d62) 12489 fix whitespace issue - [`cb3fa5f`](https://github.com/netbox-community/netbox/commit/cb3fa5f41716eb2558ec8acaecb5a8f74e8bd0b4) Undo errant commits - [`77737b5`](https://github.com/netbox-community/netbox/commit/77737b595520513553ad946f0da90a4570690b62) 12489 update site id in templates - [`183a7ae`](https://github.com/netbox-community/netbox/commit/183a7ae76ce39826d551a2c02a6bdc78c79d1c1c) Merge branch 'develop' into 12489-site-locations - [`816cee5`](https://github.com/netbox-community/netbox/commit/816cee53841d723421cde275d4b487a82aeb3726) 12489 remove nonracked_devices include ### 📊 Changes **4 files changed** (+49 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+0 -32) ➖ `netbox/templates/dcim/inc/nonracked_devices.html` (+0 -76) 📝 `netbox/templates/dcim/location.html` (+21 -1) 📝 `netbox/templates/dcim/site.html` (+28 -44) </details> ### 📄 Description ### Fixes: #12489 Changes site view to use HTMX for Locations and Non-Racked Devices in Site detail view. See before and after screenshots below. Also removed the now unused queries from the view. ![Monosnap MDF | NetBox 2023-05-04 14-39-25](https://user-images.githubusercontent.com/99642/236336265-8e10e493-b767-41ae-8800-85d2d55ccd27.png) ![Monosnap MDF | NetBox 2023-05-04 14-39-56](https://user-images.githubusercontent.com/99642/236336271-cf609d09-0df0-4915-9b95-a0903de11599.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:55 +01:00
adam closed this issue 2025-12-29 23:21:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?