[PR #12456] [MERGED] 12416 warning for missing script file #13980

New Issue

adam · 2025-12-29T23:21:52+01:00

adam commented

2025-12-29 23:21:52 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12456
Author: @arthanson
Created: 5/3/2023
Status: ✅ Merged
Merged: 5/5/2023
Merged by: @jeremystretch

Base: develop ← Head: 12416-custom-script

📝 Commits (4)

39a7472 12416 warning for missing script file
2cd14b4 12416 widen exception catching for internal script error
5976d84 Update netbox/extras/models/scripts.py
364f20f 12416 update from review feedback

📊 Changes

3 files changed (+52 additions, -39 deletions)

View changed files

📝 netbox/extras/models/scripts.py (+9 -1)
📝 netbox/extras/views.py (+0 -1)
📝 netbox/templates/extras/script_list.html (+43 -37)

📄 Description

Fixes: #12416

Fixes the case of missing script files causing the script list view to error out. Now shows a warning message for the admin to check the file (see screenshot below). Also removed a left-over print statement in the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12456 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/3/2023 **Status:** ✅ Merged **Merged:** 5/5/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12416-custom-script` --- ### 📝 Commits (4) - [`39a7472`](https://github.com/netbox-community/netbox/commit/39a74727c327f11abd275780d7b0e7505fdfc6e4) 12416 warning for missing script file - [`2cd14b4`](https://github.com/netbox-community/netbox/commit/2cd14b4dd10548f62639d104ac2a8a8a2aac42bc) 12416 widen exception catching for internal script error - [`5976d84`](https://github.com/netbox-community/netbox/commit/5976d8484e53f477df52ca52a838149fd4e408aa) Update netbox/extras/models/scripts.py - [`364f20f`](https://github.com/netbox-community/netbox/commit/364f20f620045ee58096ddc34bac764da0d3e057) 12416 update from review feedback ### 📊 Changes **3 files changed** (+52 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/scripts.py` (+9 -1) 📝 `netbox/extras/views.py` (+0 -1) 📝 `netbox/templates/extras/script_list.html` (+43 -37) </details> ### 📄 Description ### Fixes: #12416 Fixes the case of missing script files causing the script list view to error out. Now shows a warning message for the admin to check the file (see screenshot below). Also removed a left-over print statement in the code. ![Monosnap Scripts | NetBox 2023-05-03 14-26-20](https://user-images.githubusercontent.com/99642/236053537-0365aded-4245-4ff4-be64-90523a0dacda.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:52 +01:00

adam closed this issue

2025-12-29 23:21:52 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13980