[PR #12452] [MERGED] Fixes: #10757 - Change IP interface assignment to use new selector #13977

New Issue

adam · 2025-12-29T23:21:52+01:00

adam commented

2025-12-29 23:21:52 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12452
Author: @DanSheps
Created: 5/3/2023
Status: ✅ Merged
Merged: 5/4/2023
Merged by: @jeremystretch

Base: develop ← Head: 10757-fix-ip-address-form-interface-assignment

📝 Commits (2)

dd7fda1 Fixes: #10757 - Change interface assignment to use new selector. Perform the same change to the NAT assignment as well.
8adbb31 Remove nat_vrf from form and remove query_params that are not required anymore

📊 Changes

2 files changed (+6 additions, -112 deletions)

View changed files

📝 netbox/ipam/forms/model_forms.py (+6 -56)
📝 netbox/templates/ipam/ipaddress_edit.html (+0 -56)

📄 Description

Fixes: #10757

Convert the interface/FHRP assignment on IPAddress edit form to use the new selector system. This should reduce the confusion as to whether a "device" is assigned or not.

This will also resolve #11477 in a similar manner.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12452 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 5/3/2023 **Status:** ✅ Merged **Merged:** 5/4/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10757-fix-ip-address-form-interface-assignment` --- ### 📝 Commits (2) - [`dd7fda1`](https://github.com/netbox-community/netbox/commit/dd7fda1ee89a6652109167620c309d145f2374ba) Fixes: #10757 - Change interface assignment to use new selector. Perform the same change to the NAT assignment as well. - [`8adbb31`](https://github.com/netbox-community/netbox/commit/8adbb3183695f9271e5bc6efe1deb37d77f09e74) Remove nat_vrf from form and remove query_params that are not required anymore ### 📊 Changes **2 files changed** (+6 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms/model_forms.py` (+6 -56) 📝 `netbox/templates/ipam/ipaddress_edit.html` (+0 -56) </details> ### 📄 Description ### Fixes: #10757 Convert the interface/FHRP assignment on IPAddress edit form to use the new selector system. This should reduce the confusion as to whether a "device" is assigned or not. This will also resolve #11477 in a similar manner. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:52 +01:00

adam closed this issue

2025-12-29 23:21:52 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13977