starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12394] [MERGED] Feature/remote group autocreate #13961

New Issue
Closed
opened 2025-12-29 23:21:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12394
Author: @jschewebbn
Created: 4/29/2023
Status: ✅ Merged
Merged: 5/12/2023
Merged by: @jeremystretch

Base: develop ← Head: feature/remote-group-autocreate

📝 Commits (2)

  • be00b78 Add REMOTE_AUTH_AUTOCREATE_GROUPS
  • 874d1c4 Fix naming of parameter

📊 Changes

3 files changed (+50 additions, -2 deletions)

View changed files

📝 netbox/netbox/authentication.py (+5 -2)
📝 netbox/netbox/settings.py (+1 -0)
📝 netbox/netbox/tests/test_authentication.py (+44 -0)

📄 Description

Closes: https://github.com/netbox-community/netbox/issues/7671
When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups
referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the
database.

This is a rebase of https://github.com/netbox-community/netbox/pull/8603 onto the current develop with the fix noted by @kkthxbye-code.

I note that REMOTE_AUTH_AUTO_CREATE_GROUPS is plural while REMOTE_AUTH_AUTO_CREATE_USER is singular. Would the maintainers like the group parameter to be singular as well?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12394 **Author:** [@jschewebbn](https://github.com/jschewebbn) **Created:** 4/29/2023 **Status:** ✅ Merged **Merged:** 5/12/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `feature/remote-group-autocreate` --- ### 📝 Commits (2) - [`be00b78`](https://github.com/netbox-community/netbox/commit/be00b7834e0ff6a505b8b60cb698d3bdf35639ff) Add REMOTE_AUTH_AUTOCREATE_GROUPS - [`874d1c4`](https://github.com/netbox-community/netbox/commit/874d1c429407180c73b45f6684bc36abebb7b0b1) Fix naming of parameter ### 📊 Changes **3 files changed** (+50 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/authentication.py` (+5 -2) 📝 `netbox/netbox/settings.py` (+1 -0) 📝 `netbox/netbox/tests/test_authentication.py` (+44 -0) </details> ### 📄 Description Closes: https://github.com/netbox-community/netbox/issues/7671 When REMOTE_AUTH_AUTOCREATE_GROUPS is True, Netbox will create groups referenced in the REMOTE_AUTH_GROUP_HEADER that don't exist in the database. This is a rebase of https://github.com/netbox-community/netbox/pull/8603 onto the current develop with the fix noted by @kkthxbye-code. I note that REMOTE_AUTH_AUTO_CREATE_GROUPS is plural while REMOTE_AUTH_AUTO_CREATE_USER is singular. Would the maintainers like the group parameter to be singular as well? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:47 +01:00
adam closed this issue 2025-12-29 23:21:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?