[PR #12357] [MERGED] 12252 allow sorting on object in search #13955

New Issue

adam · 2025-12-29T23:21:44+01:00

adam commented

2025-12-29 23:21:44 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12357
Author: @arthanson
Created: 4/27/2023
Status: ✅ Merged
Merged: 4/27/2023
Merged by: @jeremystretch

Base: develop ← Head: 12252-search-ordering

📝 Commits (2)

bc9feb4 12252 allow sorting on object in search
875db2e 12252 code review changes

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 netbox/netbox/search/backends.py (+6 -3)
📝 netbox/netbox/tables/tables.py (+2 -1)

📄 Description

Fixes: #12252

Adds a name column (str of object) to allow sorting of the object column in search results:

tables2 looks like it only supports sorting based on items in the query results.
There is not a consistent field on object to sort on that matches the str of the object.
There are max 1,000 search results returned that are already in a list, so going through all the items as doing a str should not be too bad performance wise

The alternative would be restricting this field from being sortable, but it sounds like people want to sort on this field.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12357 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 4/27/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12252-search-ordering` --- ### 📝 Commits (2) - [`bc9feb4`](https://github.com/netbox-community/netbox/commit/bc9feb4a57e358e6e2625edb586a827a0e8cdec3) 12252 allow sorting on object in search - [`875db2e`](https://github.com/netbox-community/netbox/commit/875db2e33bee9ab3ec286dd029fe37f2da416589) 12252 code review changes ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/search/backends.py` (+6 -3) 📝 `netbox/netbox/tables/tables.py` (+2 -1) </details> ### 📄 Description ### Fixes: #12252 Adds a name column (str of object) to allow sorting of the object column in search results: 1. tables2 looks like it only supports sorting based on items in the query results. 2. There is not a consistent field on object to sort on that matches the str of the object. 3. There are max 1,000 search results returned that are already in a list, so going through all the items as doing a str should not be too bad performance wise The alternative would be restricting this field from being sortable, but it sounds like people want to sort on this field. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:44 +01:00

adam closed this issue

2025-12-29 23:21:44 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13955