starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12356] [MERGED] 11607 make CableSerializer use WritableNestedSerializer #13951

New Issue
Closed
opened 2025-12-29 23:21:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12356
Author: @arthanson
Created: 4/26/2023
Status: ✅ Merged
Merged: 4/27/2023
Merged by: @jeremystretch

Base: develop ← Head: 11607-custom-field-cable

📝 Commits (1)

  • 5d4ef5e 11607 make CableSerializer WritableNestedSerializer for to_internal value instantiation

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/dcim/api/nested_serializers.py (+1 -1)

📄 Description

Fixes: #11607

This code (https://github.com/netbox-community/netbox/blob/develop/netbox/extras/api/customfields.py#L86) assumes that the nested serializer gets instantiated after is_valid is called, this occurs for the other NestedSerializers in to_internal_value function in NestedWritableSerializer.

NestedCableSerializer was currently derived from BaseModelSerializer which doesn't do this.

@jeremystretch I'm not aware of any side-effects of deriving from WritableNestedSerializer which only adds this to_internal_value method. Not sure why NestedCableSerializer was different?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12356 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/26/2023 **Status:** ✅ Merged **Merged:** 4/27/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11607-custom-field-cable` --- ### 📝 Commits (1) - [`5d4ef5e`](https://github.com/netbox-community/netbox/commit/5d4ef5e9e54d81829f0b74e3f1529c285b8fa223) 11607 make CableSerializer WritableNestedSerializer for to_internal value instantiation ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/nested_serializers.py` (+1 -1) </details> ### 📄 Description ### Fixes: #11607 This code (https://github.com/netbox-community/netbox/blob/develop/netbox/extras/api/customfields.py#L86) assumes that the nested serializer gets instantiated after is_valid is called, this occurs for the other NestedSerializers in to_internal_value function in NestedWritableSerializer. NestedCableSerializer was currently derived from BaseModelSerializer which doesn't do this. @jeremystretch I'm not aware of any side-effects of deriving from WritableNestedSerializer which only adds this to_internal_value method. Not sure why NestedCableSerializer was different? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:43 +01:00
adam closed this issue 2025-12-29 23:21:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13951
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?