starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12248] [MERGED] Closes #12246: Utilities cleanup #13931

New Issue
Closed
opened 2025-12-29 23:21:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12248
Author: @jeremystretch
Created: 4/13/2023
Status: ✅ Merged
Merged: 4/14/2023
Merged by: @jeremystretch

Base: feature ← Head: 12246-utilities-cleanup

📝 Commits (8)

  • 2dc50b6 Clean up base modules
  • 47af8b0 Clean up forms modules
  • 134dc70 Clean up templatetags modules
  • 8d326a8 Replace custom simplify_decimal filter with floatformat
  • 8f6f397 Misc cleanup
  • 7fd7247 Merge ReturnURLForm into ConfirmationForm
  • ebfab05 Clean up import statements for utilities.forms
  • 6d78991 Fix field class references in docs

📊 Changes

87 files changed (+586 additions, -407 deletions)

View changed files

📝 docs/plugins/development/forms.md (+16 -16)
📝 netbox/circuits/forms/bulk_edit.py (+3 -3)
📝 netbox/circuits/forms/bulk_import.py (+2 -1)
📝 netbox/circuits/forms/filtersets.py (+2 -1)
📝 netbox/circuits/forms/model_forms.py (+2 -3)
📝 netbox/core/forms/bulk_edit.py (+3 -1)
📝 netbox/core/forms/filtersets.py (+3 -4)
📝 netbox/core/forms/model_forms.py (+2 -1)
📝 netbox/dcim/forms/bulk_create.py (+2 -1)
📝 netbox/dcim/forms/bulk_edit.py (+3 -4)
📝 netbox/dcim/forms/bulk_import.py (+3 -2)
📝 netbox/dcim/forms/common.py (+1 -1)
📝 netbox/dcim/forms/connections.py (+2 -2)
📝 netbox/dcim/forms/filtersets.py (+3 -4)
📝 netbox/dcim/forms/model_forms.py (+5 -4)
📝 netbox/dcim/forms/object_create.py (+1 -1)
📝 netbox/dcim/tables/template_code.py (+2 -2)
📝 netbox/extras/forms/bulk_edit.py (+3 -3)
📝 netbox/extras/forms/bulk_import.py (+2 -1)
📝 netbox/extras/forms/filtersets.py (+3 -4)

...and 67 more files

📄 Description

Closes: #12246

  • Define __all__ for each relevant module
  • Refactor form widgets module
  • Replace obsolete simplify_decimal template filter with floatformat
  • The fields and widgets submodules are no longer loaded in utilities.forms; they must be imported directly
  • Miscellaneous cleanup

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12248 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/13/2023 **Status:** ✅ Merged **Merged:** 4/14/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `12246-utilities-cleanup` --- ### 📝 Commits (8) - [`2dc50b6`](https://github.com/netbox-community/netbox/commit/2dc50b61089754bb7e1cd3cf8b31da88d3f824d2) Clean up base modules - [`47af8b0`](https://github.com/netbox-community/netbox/commit/47af8b0208fd0758927d746e3b7cf0950f882762) Clean up forms modules - [`134dc70`](https://github.com/netbox-community/netbox/commit/134dc70a4dfb8c9072d48f67f1cd87ac9177b433) Clean up templatetags modules - [`8d326a8`](https://github.com/netbox-community/netbox/commit/8d326a841aa2a72217eba19abe2a230c02914526) Replace custom simplify_decimal filter with floatformat - [`8f6f397`](https://github.com/netbox-community/netbox/commit/8f6f3973b68e74539e4189e809234b0c606bc4df) Misc cleanup - [`7fd7247`](https://github.com/netbox-community/netbox/commit/7fd72477ab36055d4e0024c73a7bdc64e379743b) Merge ReturnURLForm into ConfirmationForm - [`ebfab05`](https://github.com/netbox-community/netbox/commit/ebfab052043f86a61e5f6b3837ba0f783162389c) Clean up import statements for utilities.forms - [`6d78991`](https://github.com/netbox-community/netbox/commit/6d78991bae223f1ab7f94bbfbf52b2d4af52c12f) Fix field class references in docs ### 📊 Changes **87 files changed** (+586 additions, -407 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/forms.md` (+16 -16) 📝 `netbox/circuits/forms/bulk_edit.py` (+3 -3) 📝 `netbox/circuits/forms/bulk_import.py` (+2 -1) 📝 `netbox/circuits/forms/filtersets.py` (+2 -1) 📝 `netbox/circuits/forms/model_forms.py` (+2 -3) 📝 `netbox/core/forms/bulk_edit.py` (+3 -1) 📝 `netbox/core/forms/filtersets.py` (+3 -4) 📝 `netbox/core/forms/model_forms.py` (+2 -1) 📝 `netbox/dcim/forms/bulk_create.py` (+2 -1) 📝 `netbox/dcim/forms/bulk_edit.py` (+3 -4) 📝 `netbox/dcim/forms/bulk_import.py` (+3 -2) 📝 `netbox/dcim/forms/common.py` (+1 -1) 📝 `netbox/dcim/forms/connections.py` (+2 -2) 📝 `netbox/dcim/forms/filtersets.py` (+3 -4) 📝 `netbox/dcim/forms/model_forms.py` (+5 -4) 📝 `netbox/dcim/forms/object_create.py` (+1 -1) 📝 `netbox/dcim/tables/template_code.py` (+2 -2) 📝 `netbox/extras/forms/bulk_edit.py` (+3 -3) 📝 `netbox/extras/forms/bulk_import.py` (+2 -1) 📝 `netbox/extras/forms/filtersets.py` (+3 -4) _...and 67 more files_ </details> ### 📄 Description ### Closes: #12246 - Define `__all__` for each relevant module - Refactor form widgets module - Replace obsolete `simplify_decimal` template filter with `floatformat` - The `fields` and `widgets` submodules are no longer loaded in `utilities.forms`; they must be imported directly - Miscellaneous cleanup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:37 +01:00
adam closed this issue 2025-12-29 23:21:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?