starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12070] [MERGED] Closes #12067: Rename & move JobResult #13901

New Issue
Closed
opened 2025-12-29 23:21:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12070
Author: @jeremystretch
Created: 3/27/2023
Status: ✅ Merged
Merged: 3/27/2023
Merged by: @jeremystretch

Base: feature ← Head: 12067-core-jobs

📝 Commits (5)

  • 8b368cd Rename JobResult to Job and move to core
  • 2c0f1cd Rename JOBRESULT_RETENTION to JOB_RETENTION
  • be2d5aa Update release notes
  • 98a80d4 Replicate JobResults to new Job model
  • 41ead58 Remove the old JobResult model

📊 Changes

49 files changed (+756 additions, -567 deletions)

View changed files

📝 docs/administration/housekeeping.md (+1 -1)
📝 docs/configuration/index.md (+1 -1)
📝 docs/configuration/miscellaneous.md (+5 -3)
📝 docs/development/models.md (+1 -1)
📝 docs/features/background-jobs.md (+1 -1)
📝 docs/models/core/job.md (+2 -2)
📝 docs/release-notes/version-3.5.md (+14 -1)
📝 mkdocs.yml (+1 -1)
📝 netbox/core/api/nested_serializers.py (+18 -2)
📝 netbox/core/api/serializers.py (+23 -2)
📝 netbox/core/api/urls.py (+3 -0)
📝 netbox/core/api/views.py (+10 -4)
📝 netbox/core/choices.py (+29 -0)
📝 netbox/core/filtersets.py (+61 -1)
📝 netbox/core/forms/filtersets.py (+69 -1)
📝 netbox/core/jobs.py (+2 -2)
➕ netbox/core/migrations/0003_job.py (+40 -0)
➕ netbox/core/migrations/0004_replicate_jobresults.py (+45 -0)
➕ netbox/core/migrations/0005_job_created_auto_now.py (+18 -0)
📝 netbox/core/models/__init__.py (+1 -0)

...and 29 more files

📄 Description

Closes: #12067

  • Rename extras.JobResult to core.Job
  • Rename the model's obj_type field to object_type
  • Migrate the /api/extras/job-results/ REST API endpoint to /api/core/jobs/
  • Rename JobResultsMixin to JobsMixin
  • Rename JOBRESULT_RETENTION config parameter to JOB_RETENTION
  • Migrate all existing JobResult records to the new Job model
  • Delete the old JobResult model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12070 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/27/2023 **Status:** ✅ Merged **Merged:** 3/27/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `12067-core-jobs` --- ### 📝 Commits (5) - [`8b368cd`](https://github.com/netbox-community/netbox/commit/8b368cdf69aa9de70ef40111c7e2f1c41c63ee2f) Rename JobResult to Job and move to core - [`2c0f1cd`](https://github.com/netbox-community/netbox/commit/2c0f1cd0ae61c49bdffdbdcdeacca0a2b2fe62ca) Rename JOBRESULT_RETENTION to JOB_RETENTION - [`be2d5aa`](https://github.com/netbox-community/netbox/commit/be2d5aab1728bcde76c4d278518adea4bb9fc979) Update release notes - [`98a80d4`](https://github.com/netbox-community/netbox/commit/98a80d448fac47eb575be92f3604b293da7c068e) Replicate JobResults to new Job model - [`41ead58`](https://github.com/netbox-community/netbox/commit/41ead5888fe5b1b58de4ca4cf9988db4a5fa6878) Remove the old JobResult model ### 📊 Changes **49 files changed** (+756 additions, -567 deletions) <details> <summary>View changed files</summary> 📝 `docs/administration/housekeeping.md` (+1 -1) 📝 `docs/configuration/index.md` (+1 -1) 📝 `docs/configuration/miscellaneous.md` (+5 -3) 📝 `docs/development/models.md` (+1 -1) 📝 `docs/features/background-jobs.md` (+1 -1) 📝 `docs/models/core/job.md` (+2 -2) 📝 `docs/release-notes/version-3.5.md` (+14 -1) 📝 `mkdocs.yml` (+1 -1) 📝 `netbox/core/api/nested_serializers.py` (+18 -2) 📝 `netbox/core/api/serializers.py` (+23 -2) 📝 `netbox/core/api/urls.py` (+3 -0) 📝 `netbox/core/api/views.py` (+10 -4) 📝 `netbox/core/choices.py` (+29 -0) 📝 `netbox/core/filtersets.py` (+61 -1) 📝 `netbox/core/forms/filtersets.py` (+69 -1) 📝 `netbox/core/jobs.py` (+2 -2) ➕ `netbox/core/migrations/0003_job.py` (+40 -0) ➕ `netbox/core/migrations/0004_replicate_jobresults.py` (+45 -0) ➕ `netbox/core/migrations/0005_job_created_auto_now.py` (+18 -0) 📝 `netbox/core/models/__init__.py` (+1 -0) _...and 29 more files_ </details> ### 📄 Description ### Closes: #12067 - Rename `extras.JobResult` to `core.Job` - Rename the model's `obj_type` field to `object_type` - Migrate the `/api/extras/job-results/` REST API endpoint to `/api/core/jobs/` - Rename `JobResultsMixin` to `JobsMixin` - Rename `JOBRESULT_RETENTION` config parameter to `JOB_RETENTION` - Migrate all existing `JobResult` records to the new `Job` model - Delete the old `JobResult` model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:27 +01:00
adam closed this issue 2025-12-29 23:21:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?