starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #11950] [CLOSED] Closes #11942: Peer-review workflow #13871

New Issue
Closed
opened 2025-12-29 23:21:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11950
Author: @rmanyari
Created: 3/10/2023
Status: ❌ Closed

Base: develop ← Head: poc-peer-review

📝 Commits (10+)

  • 1e2a333 Fixes #11470: Validation and user friendly message on invalid address query param
  • fe14cdf Update invalid input handling to return empty set instead of raising exception
  • d9a1f5d Merge branch 'netbox-community:develop' into develop
  • ada027f Fixes #11942: Add notifications model and REST API impl
  • 1f70360 Remove unnecessary import
  • 59c99dd review request model
  • c72dabd object edit updates, basic review request submittion
  • 69b09d5 review request view
  • e10aa0a remove unnecessary print statements, fix typo, tweaks in str fns
  • 17ffd5d actions on review request view, more tweaks

📊 Changes

26 files changed (+799 additions, -34 deletions)

View changed files

📝 netbox/dcim/tables/devices.py (+5 -0)
📝 netbox/dcim/views.py (+9 -1)
📝 netbox/extras/api/serializers.py (+26 -0)
📝 netbox/extras/api/urls.py (+2 -0)
📝 netbox/extras/api/views.py (+43 -0)
📝 netbox/extras/choices.py (+24 -0)
📝 netbox/extras/forms/model_forms.py (+1 -0)
➕ netbox/extras/migrations/0085_reviewrequest_notification.py (+52 -0)
➕ netbox/extras/migrations/0086_alter_notification_user.py (+21 -0)
📝 netbox/extras/models/staging.py (+107 -4)
📝 netbox/extras/tables/tables.py (+45 -1)
📝 netbox/extras/tests/test_api.py (+85 -0)
📝 netbox/extras/urls.py (+5 -1)
📝 netbox/extras/views.py (+112 -1)
📝 netbox/netbox/navigation/menu.py (+1 -0)
📝 netbox/netbox/tables/columns.py (+1 -0)
📝 netbox/netbox/tests/test_staging.py (+6 -6)
📝 netbox/netbox/views/generic/object_views.py (+72 -19)
➕ netbox/templates/extras/reviewrequest.html (+96 -0)
📝 netbox/templates/generic/object.html (+3 -0)

...and 6 more files

📄 Description

Closes: #11942

  • Notification model in staging zone.
  • ReviewRequest model in staging zone.
  • Basic REST API implementation under extras. Still WIP.
  • Support to suggest edits through the UI on Device models.
  • Generic suggest view and suggest_form_factory implementation.
  • Generic changes to ObjectEditView to support suggest action.
  • Update Branch __str__ function to convey information about the staged changes.
  • Add properties to Branch to make it easier to display the differences.
  • ReviewRequest and StagedChange tables implementation.
  • ReviewRequest views to list, view, approve and deny requests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11950 **Author:** [@rmanyari](https://github.com/rmanyari) **Created:** 3/10/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `poc-peer-review` --- ### 📝 Commits (10+) - [`1e2a333`](https://github.com/netbox-community/netbox/commit/1e2a33337f5a9449f9593f74be8162d1b87fb5de) Fixes #11470: Validation and user friendly message on invalid address query param - [`fe14cdf`](https://github.com/netbox-community/netbox/commit/fe14cdf07c35a1579c79145f15dd1157d93488d7) Update invalid input handling to return empty set instead of raising exception - [`d9a1f5d`](https://github.com/netbox-community/netbox/commit/d9a1f5d06a1fa961aa226517b85031da73f0ea9f) Merge branch 'netbox-community:develop' into develop - [`ada027f`](https://github.com/netbox-community/netbox/commit/ada027fd1454d314c470825786a7417c8dd23b58) Fixes #11942: Add notifications model and REST API impl - [`1f70360`](https://github.com/netbox-community/netbox/commit/1f70360592334dffa7a0a0b9058adfbc29b0d0eb) Remove unnecessary import - [`59c99dd`](https://github.com/netbox-community/netbox/commit/59c99ddbfea9a540fcfb4f4f1189c6286998c56c) review request model - [`c72dabd`](https://github.com/netbox-community/netbox/commit/c72dabd450fac1afd2c3a482e1092481d24c6e9d) object edit updates, basic review request submittion - [`69b09d5`](https://github.com/netbox-community/netbox/commit/69b09d515409cae67ac7d5bae63dc2a6d1a77f27) review request view - [`e10aa0a`](https://github.com/netbox-community/netbox/commit/e10aa0afdb4eaafeebc475ee5529097016bfaef2) remove unnecessary print statements, fix typo, tweaks in str fns - [`17ffd5d`](https://github.com/netbox-community/netbox/commit/17ffd5d776f0957d134a766d40c995b18399bec3) actions on review request view, more tweaks ### 📊 Changes **26 files changed** (+799 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/devices.py` (+5 -0) 📝 `netbox/dcim/views.py` (+9 -1) 📝 `netbox/extras/api/serializers.py` (+26 -0) 📝 `netbox/extras/api/urls.py` (+2 -0) 📝 `netbox/extras/api/views.py` (+43 -0) 📝 `netbox/extras/choices.py` (+24 -0) 📝 `netbox/extras/forms/model_forms.py` (+1 -0) ➕ `netbox/extras/migrations/0085_reviewrequest_notification.py` (+52 -0) ➕ `netbox/extras/migrations/0086_alter_notification_user.py` (+21 -0) 📝 `netbox/extras/models/staging.py` (+107 -4) 📝 `netbox/extras/tables/tables.py` (+45 -1) 📝 `netbox/extras/tests/test_api.py` (+85 -0) 📝 `netbox/extras/urls.py` (+5 -1) 📝 `netbox/extras/views.py` (+112 -1) 📝 `netbox/netbox/navigation/menu.py` (+1 -0) 📝 `netbox/netbox/tables/columns.py` (+1 -0) 📝 `netbox/netbox/tests/test_staging.py` (+6 -6) 📝 `netbox/netbox/views/generic/object_views.py` (+72 -19) ➕ `netbox/templates/extras/reviewrequest.html` (+96 -0) 📝 `netbox/templates/generic/object.html` (+3 -0) _...and 6 more files_ </details> ### 📄 Description ### Closes: #11942 * Notification model in `staging` zone. * ReviewRequest model in `staging` zone. * Basic REST API implementation under `extras`. Still WIP. * Support to suggest edits through the UI on `Device` models. * Generic suggest view and `suggest_form_factory` implementation. * Generic changes to `ObjectEditView` to support `suggest` action. * Update `Branch` `__str__` function to convey information about the staged changes. * Add properties to `Branch` to make it easier to display the differences. * `ReviewRequest` and `StagedChange` tables implementation. * `ReviewRequest` views to list, view, approve and deny requests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:17 +01:00
adam closed this issue 2025-12-29 23:21:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13871
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?