starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #11858] [MERGED] Fixes #11470: Validation and user friendly message on invalid address query param #13856

New Issue
Closed
opened 2025-12-29 23:21:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11858
Author: @rmanyari
Created: 2/28/2023
Status: ✅ Merged
Merged: 3/1/2023
Merged by: @jeremystretch

Base: develop ← Head: develop

📝 Commits (2)

  • 1e2a333 Fixes #11470: Validation and user friendly message on invalid address query param
  • fe14cdf Update invalid input handling to return empty set instead of raising exception

📊 Changes

2 files changed (+48 additions, -0 deletions)

View changed files

📝 netbox/ipam/filtersets.py (+27 -0)
📝 netbox/ipam/tests/test_filtersets.py (+21 -0)

📄 Description

Fixes: #11470

  • Adds address query param validation to support valid network ranges and IP address.
  • Raises user-friendly error message on invalid input.
  • Additional unit tests for edge case coverage and invalid input

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11858 **Author:** [@rmanyari](https://github.com/rmanyari) **Created:** 2/28/2023 **Status:** ✅ Merged **Merged:** 3/1/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`1e2a333`](https://github.com/netbox-community/netbox/commit/1e2a33337f5a9449f9593f74be8162d1b87fb5de) Fixes #11470: Validation and user friendly message on invalid address query param - [`fe14cdf`](https://github.com/netbox-community/netbox/commit/fe14cdf07c35a1579c79145f15dd1157d93488d7) Update invalid input handling to return empty set instead of raising exception ### 📊 Changes **2 files changed** (+48 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/filtersets.py` (+27 -0) 📝 `netbox/ipam/tests/test_filtersets.py` (+21 -0) </details> ### 📄 Description ### Fixes: #11470 * Adds address query param validation to support valid network ranges and IP address. * Raises user-friendly error message on invalid input. * Additional unit tests for edge case coverage and invalid input --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:12 +01:00
adam closed this issue 2025-12-29 23:21:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?