starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Rewrite all imports to pull constants from constants.py instead of models.py #1385

New Issue
Closed
opened 2025-12-29 16:31:57 +01:00 by adam · 1 comment
adam commented 2025-12-29 16:31:57 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 6, 2017).

Issue type

[x] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: 2.2.4

Description

This issue is just for housekeeping. A while back we moved all constant variable declarations into a constants.py file within each app, but many of the import statements were never updated and still pull constants indirectly via models.py.

Originally created by @jeremystretch on GitHub (Nov 6, 2017). ### Issue type [x] Feature request <!-- An enhancement of existing functionality --> [ ] Bug report <!-- Unexpected or erroneous behavior --> [ ] Documentation <!-- A modification to the documentation --> ### Environment * Python version: 3.5.2 * NetBox version: 2.2.4 ### Description This issue is just for housekeeping. A while back we moved all constant variable declarations into a `constants.py` file within each app, but many of the import statements were never updated and still pull constants indirectly via `models.py`.
adam added the type: housekeeping label 2025-12-29 16:31:57 +01:00
adam closed this issue 2025-12-29 16:31:58 +01:00
adam commented 2025-12-29 16:31:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 7, 2017):

I've also taken this opportunity to reorganize all import statements. The resulting diff looks huge but it's merely housekeeping.

@jeremystretch commented on GitHub (Nov 7, 2017): I've also taken this opportunity to reorganize all import statements. The resulting diff looks huge but it's merely housekeeping.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?