[PR #11784] [MERGED] Fixes #11539: Use BooleanFilter for 'empty' lookups #13841

New Issue

adam · 2025-12-29T23:21:07+01:00

adam commented

2025-12-29 23:21:07 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11784
Author: @jeremystretch
Created: 2/17/2023
Status: ✅ Merged
Merged: 5/25/2023
Merged by: @jeremystretch

Base: develop ← Head: 11539-empty-lookups

📝 Commits (3)

93a80c6 Use BooleanFilter for 'empty' lookups
f632a53 Always use BooleanFilter for 'empty' lookups
ada6ab0 Restore Empty lookup logic

📊 Changes

2 files changed (+17 additions, -6 deletions)

View changed files

📝 netbox/extras/lookups.py (+7 -5)
📝 netbox/netbox/filtersets.py (+10 -1)

📄 Description

Fixes: #11539

Clean up our custom Empty lookup to more accurately evaluate true/false conditions
Force the use of BooleanFilter for empty lookups in requests

While this seems to address the bug for most fields, I still need to figure out how to correct the filter class for declared filters, such DeviceFilterSet.name (which is the actual target of the bug report).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11784 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/17/2023 **Status:** ✅ Merged **Merged:** 5/25/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11539-empty-lookups` --- ### 📝 Commits (3) - [`93a80c6`](https://github.com/netbox-community/netbox/commit/93a80c6580cdafce2f71aac386e91ae511f9dd9e) Use BooleanFilter for 'empty' lookups - [`f632a53`](https://github.com/netbox-community/netbox/commit/f632a536d438e2679816c258e7afb34e1283e077) Always use BooleanFilter for 'empty' lookups - [`ada6ab0`](https://github.com/netbox-community/netbox/commit/ada6ab0b85e2caaa950128ba6751aa1f8abbc26c) Restore Empty lookup logic ### 📊 Changes **2 files changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/lookups.py` (+7 -5) 📝 `netbox/netbox/filtersets.py` (+10 -1) </details> ### 📄 Description ### Fixes: #11539 - Clean up our custom `Empty` lookup to more accurately evaluate true/false conditions - Force the use of BooleanFilter for `empty` lookups in requests While this seems to address the bug for _most_ fields, I still need to figure out how to correct the filter class for declared filters, such `DeviceFilterSet.name` (which is the actual target of the bug report). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:07 +01:00

adam closed this issue

2025-12-29 23:21:07 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13841