[PR #11724] [MERGED] Fixes #11565 - Populate custom field defaults when creating FHRP groups with VIP #13831

New Issue

adam · 2025-12-29T23:21:03+01:00

adam commented

2025-12-29 23:21:03 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11724
Author: @kkthxbye-code
Created: 2/10/2023
Status: ✅ Merged
Merged: 2/27/2023
Merged by: @jeremystretch

Base: develop ← Head: 11565-fix-fhrp-cf

📝 Commits (1)

7e290a3 Fixes #11565 - Populate custom field defaults when creating FHRP groups with VIP

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 netbox/ipam/forms/model_forms.py (+1 -0)
📝 netbox/netbox/models/features.py (+7 -0)

📄 Description

Fixes: #11565

Creates a new method in CustomFieldMixin for populating defaults. It is utilized when creating the IP during FHRP creation.

I created a method on the model because it seems likely there's other places where we manually create objects during the creation of other objects. We might look into just always applying the defaults whenever an object with CustomFieldMixin is instantiated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11724 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 2/10/2023 **Status:** ✅ Merged **Merged:** 2/27/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11565-fix-fhrp-cf` --- ### 📝 Commits (1) - [`7e290a3`](https://github.com/netbox-community/netbox/commit/7e290a360f7cf32a68a4f83bf0ca054fb0c7c133) Fixes #11565 - Populate custom field defaults when creating FHRP groups with VIP ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms/model_forms.py` (+1 -0) 📝 `netbox/netbox/models/features.py` (+7 -0) </details> ### 📄 Description ### Fixes: #11565 Creates a new method in CustomFieldMixin for populating defaults. It is utilized when creating the IP during FHRP creation. I created a method on the model because it seems likely there's other places where we manually create objects during the creation of other objects. We might look into just always applying the defaults whenever an object with CustomFieldMixin is instantiated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:03 +01:00

adam closed this issue

2025-12-29 23:21:04 +01:00

Sign in to join this conversation.

Branches Tags

main

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13831