[PR #11722] [MERGED] Fixes #11459 - Allow using null in conditions #13829

New Issue

adam · 2025-12-29T23:21:02+01:00

adam commented

2025-12-29 23:21:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11722
Author: @kkthxbye-code
Created: 2/10/2023
Status: ✅ Merged
Merged: 2/13/2023
Merged by: @jeremystretch

Base: develop ← Head: 11459

📝 Commits (2)

90d5950 Fixes #11459 - Allow using null in conditions
7e493f2 Update netbox/extras/conditions.py

📊 Changes

3 files changed (+15 additions, -4 deletions)

View changed files

📝 docs/reference/conditions.md (+3 -3)
📝 netbox/extras/conditions.py (+2 -1)
📝 netbox/extras/tests/test_conditions.py (+10 -0)

📄 Description

Fixes: #11459

Issue here was two-fold I believe. First issue is that primary_ip is always None when evaluating the conditions as computed properties are not serialized when queuing webhooks.

The other issue is that comparing "" with None is False. Allowing conditions to contain null/None allows to compare against None instead of empty string which was not functional.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11722 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 2/10/2023 **Status:** ✅ Merged **Merged:** 2/13/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11459` --- ### 📝 Commits (2) - [`90d5950`](https://github.com/netbox-community/netbox/commit/90d595066df7292c1c1786e8b97eda6e280c503e) Fixes #11459 - Allow using null in conditions - [`7e493f2`](https://github.com/netbox-community/netbox/commit/7e493f2935c3d41bdd658d368ff985ac0b4d9837) Update netbox/extras/conditions.py ### 📊 Changes **3 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/reference/conditions.md` (+3 -3) 📝 `netbox/extras/conditions.py` (+2 -1) 📝 `netbox/extras/tests/test_conditions.py` (+10 -0) </details> ### 📄 Description ### Fixes: #11459 Issue here was two-fold I believe. First issue is that primary_ip is always None when evaluating the conditions as computed properties are not serialized when queuing webhooks. The other issue is that comparing "" with None is False. Allowing conditions to contain `null`/`None` allows to compare against None instead of empty string which was not functional. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:21:02 +01:00

adam closed this issue

2025-12-29 23:21:03 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13829