starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #11697] [MERGED] Fixes #11601 - Add partial lookup to IPRangeFilterSet #13824

New Issue
Closed
opened 2025-12-29 23:21:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11697
Author: @kkthxbye-code
Created: 2/8/2023
Status: ✅ Merged
Merged: 2/8/2023
Merged by: @jeremystretch

Base: develop ← Head: 11601-iprange-partial-lookup

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 netbox/ipam/filtersets.py (+2 -2)

📄 Description

Fixes: #11601

Allows partial lookup in the search method for IPRange. Also removes the .cidr from the parsed IP lookup as I really don't see how it makes sense.

The changes makes it so that the following matches (192.168.0.1/25-192.168.0.25/25, which didn't before:
192
192.16
192.168.0.1/25 <- even the full IP with mask didn't match before because of using the cidr.
192.168.0.25/25

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11697 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 2/8/2023 **Status:** ✅ Merged **Merged:** 2/8/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11601-iprange-partial-lookup` --- ### 📝 Commits (1) - [`69c921a`](https://github.com/netbox-community/netbox/commit/69c921aacff4af758921e79198d8dd62344cfb8b) Fixes #11601 - Add partial lookup to IPRangeFilterSet ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/filtersets.py` (+2 -2) </details> ### 📄 Description ### Fixes: #11601 Allows partial lookup in the search method for IPRange. Also removes the `.cidr` from the parsed IP lookup as I really don't see how it makes sense. The changes makes it so that the following matches (192.168.0.1/25-192.168.0.25/25, which didn't before: 192 192.16 192.168.0.1/25 <- even the full IP with mask didn't match before because of using the cidr. 192.168.0.25/25 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:01 +01:00
adam closed this issue 2025-12-29 23:21:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?