[PR #11346] [MERGED] Fixes #11345 - Fix module validation #13775

New Issue

adam · 2025-12-29T23:20:44+01:00

adam commented

2025-12-29 23:20:44 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11346
Author: @kkthxbye-code
Created: 12/30/2022
Status: ✅ Merged
Merged: 1/3/2023
Merged by: @jeremystretch

Base: develop ← Head: 11345-fix-module-validation

📝 Commits (2)

472542b Make sure we bail out if field validation failed when importing modules
1b696f5 Tweak form validation logic

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 netbox/dcim/forms/common.py (+5 -4)
📝 netbox/dcim/models/devices.py (+1 -1)

📄 Description

Fixes: #11345

The issue was that validation of module component replication/adoption was executed even if field validation failed. The model also had a validation step that would throw an exception when no module_bay was set (which was the case when trying to import to a non-existant module bay).

I'm not sure if this is actually the preferred way to do this:

cleaned_data = super().clean()

# Skip form validation if field validation already found errors.
if self.errors:
    return cleaned_data

Please let me know if there is a smarted way to bail out if field validation (non-existant device for example) has already failed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11346 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 12/30/2022 **Status:** ✅ Merged **Merged:** 1/3/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11345-fix-module-validation` --- ### 📝 Commits (2) - [`472542b`](https://github.com/netbox-community/netbox/commit/472542b888778c60aca412c55ccf41ded44f2914) Make sure we bail out if field validation failed when importing modules - [`1b696f5`](https://github.com/netbox-community/netbox/commit/1b696f58a5c7c6c03d80deb04f4046b9427e264d) Tweak form validation logic ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/common.py` (+5 -4) 📝 `netbox/dcim/models/devices.py` (+1 -1) </details> ### 📄 Description ### Fixes: #11345 The issue was that validation of module component replication/adoption was executed even if field validation failed. The model also had a validation step that would throw an exception when no module_bay was set (which was the case when trying to import to a non-existant module bay). I'm not sure if this is actually the preferred way to do this: ``` cleaned_data = super().clean() # Skip form validation if field validation already found errors. if self.errors: return cleaned_data ``` Please let me know if there is a smarted way to bail out if field validation (non-existant device for example) has already failed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:20:44 +01:00

adam closed this issue

2025-12-29 23:20:44 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13775