starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #11285] [MERGED] Fixes #11280 - Fix exporting interfaces and FHRP group rows with multiple IP's assigned #13763

New Issue
Closed
opened 2025-12-29 23:20:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:20:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11285
Author: @kkthxbye-code
Created: 12/21/2022
Status: ✅ Merged
Merged: 12/27/2022
Merged by: @jeremystretch

Base: develop ← Head: 11280-fix-ipaddress-export

📝 Commits (2)

  • 81369a3 Fix ip_address table column export when multiple IP's are assigned
  • cb4c6ea Fix pep8

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 netbox/dcim/tables/devices.py (+3 -0)
📝 netbox/ipam/tables/fhrp.py (+3 -0)

📄 Description

Fixes: #11280

Adds value_ip_address method to BaseInterfaceTable and FHRPGroupTable.

@jeremystretch - Let me know if we should create a new column extending TemplateColumn for IPAddresses instead. I felt like it might be overkill, but there is slight replication of code in the current fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11285 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 12/21/2022 **Status:** ✅ Merged **Merged:** 12/27/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11280-fix-ipaddress-export` --- ### 📝 Commits (2) - [`81369a3`](https://github.com/netbox-community/netbox/commit/81369a3768260d601ee497c02150b5451da4f093) Fix ip_address table column export when multiple IP's are assigned - [`cb4c6ea`](https://github.com/netbox-community/netbox/commit/cb4c6eaa25a1229efdc5fdfb1046b5d553843eda) Fix pep8 ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/devices.py` (+3 -0) 📝 `netbox/ipam/tables/fhrp.py` (+3 -0) </details> ### 📄 Description ### Fixes: #11280 Adds `value_ip_address` method to BaseInterfaceTable and FHRPGroupTable. @jeremystretch - Let me know if we should create a new column extending TemplateColumn for IPAddresses instead. I felt like it might be overkill, but there is slight replication of code in the current fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:20:39 +01:00
adam closed this issue 2025-12-29 23:20:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13763
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?