starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10954] [CLOSED] Fixes #10950 - Add filtering and validation to primary_ip4/primary_ip6 VirtualDeviceContext model #13723

New Issue
Closed
opened 2025-12-29 23:20:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:20:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10954
Author: @DanSheps
Created: 11/17/2022
Status: ❌ Closed

Base: feature ← Head: 100950-vdc-fix-primary_ip4_primary_ip6

📝 Commits (2)

  • a85d1b1 Add validation and filtering for device on primary_ip4/primary_ip6 for VDC model
  • 6a63b71 Further constrain IP to VDC

📊 Changes

3 files changed (+60 additions, -3 deletions)

View changed files

📝 netbox/dcim/forms/model_forms.py (+29 -0)
📝 netbox/dcim/models/devices.py (+21 -0)
📝 netbox/ipam/models/ip.py (+10 -3)

📄 Description

Fixes: #10950

  • Adds filtering to VirtualDeviceContext model_form
  • Adds validation to VirtualDeviceContext model
  • Adds validation to IPAddress model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10954 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 11/17/2022 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `100950-vdc-fix-primary_ip4_primary_ip6` --- ### 📝 Commits (2) - [`a85d1b1`](https://github.com/netbox-community/netbox/commit/a85d1b13194694e3fea891e199ad0ee5bf414b80) Add validation and filtering for device on primary_ip4/primary_ip6 for VDC model - [`6a63b71`](https://github.com/netbox-community/netbox/commit/6a63b71e15520c1b41996c30ff99ea511e2ada4f) Further constrain IP to VDC ### 📊 Changes **3 files changed** (+60 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/model_forms.py` (+29 -0) 📝 `netbox/dcim/models/devices.py` (+21 -0) 📝 `netbox/ipam/models/ip.py` (+10 -3) </details> ### 📄 Description ### Fixes: #10950 * Adds filtering to VirtualDeviceContext model_form * Adds validation to VirtualDeviceContext model * Adds validation to IPAddress model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:20:27 +01:00
adam closed this issue 2025-12-29 23:20:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13723
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?