starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10843] [MERGED] 10653 log failed login attempts on INFO #13704

New Issue
Closed
opened 2025-12-29 23:20:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:20:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10843
Author: @arthanson
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/18/2022
Merged by: @jeremystretch

Base: develop ← Head: 10653-log-failed-logins

📝 Commits (6)

  • 135fab6 10653 log failed login attempts on INFO
  • 2b2a50a Merge branch 'develop' into 10653-log-failed-logins
  • 8df1626 10653 use signal to log failed login attempts
  • 6f908f8 10653 use signal to log failed login attempts
  • 1135019 Update netbox/users/signals.py
  • 1cdd110 Update netbox/users/apps.py

📊 Changes

3 files changed (+19 additions, -1 deletions)

View changed files

➕ netbox/users/apps.py (+8 -0)
➕ netbox/users/signals.py (+10 -0)
📝 netbox/users/views.py (+1 -1)

📄 Description

Fixes: #10653

@jeremystretch Not completely sure of what is the best way here. The log was done for failed login attempts but at DEBUG level which would be fairly spammy to have on, changed to INFO level also included failed username - I don't think that would violate personal-identifiable-information security issues... Probably up for discussion if this makes sense to change (from a logging standpoint if that is too much info for some people, and security if the username should be shown).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10843 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/18/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10653-log-failed-logins` --- ### 📝 Commits (6) - [`135fab6`](https://github.com/netbox-community/netbox/commit/135fab6c35dc2d51a62e1357fa8c7e08bc704b82) 10653 log failed login attempts on INFO - [`2b2a50a`](https://github.com/netbox-community/netbox/commit/2b2a50ac3ad7784ad746fb55187b25f438ac0155) Merge branch 'develop' into 10653-log-failed-logins - [`8df1626`](https://github.com/netbox-community/netbox/commit/8df162649b181ce76f8cf7fbb9228f53a3df6494) 10653 use signal to log failed login attempts - [`6f908f8`](https://github.com/netbox-community/netbox/commit/6f908f8cbf404fd1e18c1aa875fc5b65132036ba) 10653 use signal to log failed login attempts - [`1135019`](https://github.com/netbox-community/netbox/commit/1135019d0244992c312bb10305b729f490ee140a) Update netbox/users/signals.py - [`1cdd110`](https://github.com/netbox-community/netbox/commit/1cdd11045303670e4230a4cf8bceeefab6b3d1b0) Update netbox/users/apps.py ### 📊 Changes **3 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `netbox/users/apps.py` (+8 -0) ➕ `netbox/users/signals.py` (+10 -0) 📝 `netbox/users/views.py` (+1 -1) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #10653 <!-- Please include a summary of the proposed changes below. --> @jeremystretch Not completely sure of what is the best way here. The log was done for failed login attempts but at DEBUG level which would be fairly spammy to have on, changed to INFO level also included failed username - I don't think that would violate personal-identifiable-information security issues... Probably up for discussion if this makes sense to change (from a logging standpoint if that is too much info for some people, and security if the username should be shown). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:20:21 +01:00
adam closed this issue 2025-12-29 23:20:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?