starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10742] [MERGED] Closes #10739: Introduce get_queryset() method on generic views #13684

New Issue
Closed
opened 2025-12-29 23:20:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:20:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10742
Author: @jeremystretch
Created: 10/25/2022
Status: ✅ Merged
Merged: 10/25/2022
Merged by: @jeremystretch

Base: feature ← Head: 10739-generic-view-querysets

📝 Commits (1)

  • 3c30c67 Closes #10739: Introduce get_queryset() method on generic views

📊 Changes

3 files changed (+38 additions, -10 deletions)

View changed files

📝 docs/plugins/development/views.md (+10 -4)
📝 docs/release-notes/version-3.4.md (+1 -0)
📝 netbox/netbox/views/generic/base.py (+27 -6)

📄 Description

Fixes: #10739

  • Introduce new BaseView base class for all generic views
  • Add a get_queryset() method which accepts the current request as its only argument
  • Call get_queryset() within dispatch() for each request
  • Update plugin development documentation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10742 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 10/25/2022 **Status:** ✅ Merged **Merged:** 10/25/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `10739-generic-view-querysets` --- ### 📝 Commits (1) - [`3c30c67`](https://github.com/netbox-community/netbox/commit/3c30c6708f1def99bac76b55d172eb452276a6d4) Closes #10739: Introduce get_queryset() method on generic views ### 📊 Changes **3 files changed** (+38 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/views.md` (+10 -4) 📝 `docs/release-notes/version-3.4.md` (+1 -0) 📝 `netbox/netbox/views/generic/base.py` (+27 -6) </details> ### 📄 Description ### Fixes: #10739 - Introduce new `BaseView` base class for all generic views - Add a `get_queryset()` method which accepts the current request as its only argument - Call `get_queryset()` within `dispatch()` for each request - Update plugin development documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:20:15 +01:00
adam closed this issue 2025-12-29 23:20:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?