starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10458] [CLOSED] 10458 add "Location" to CircuitTermination #13635

New Issue
Closed
opened 2025-12-29 23:19:59 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:59 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10458
Author: @gjvc
Created: 9/26/2022
Status: ❌ Closed

Base: develop ← Head: 9604-add-location-to-circuittermination

📝 Commits (7)

  • f193dd4 add "Location" to CircuitTermination
  • d6e093f minor diff cleanups
  • a2453c5 update CIRCUITTERMINATION_LINK
  • 623a739 update CIRCUITTERMINATION_LINK
  • 54769af CIRCUITTERMINATION_LINK -> CIRCUIT_TERMINATION_LINK
  • 24cc5ed Merge branch 'develop' into 9604-add-location-to-circuittermination
  • 9901091 cleanup

📊 Changes

7 files changed (+57 additions, -5 deletions)

View changed files

📝 netbox/circuits/forms/models.py (+10 -2)
➕ netbox/circuits/migrations/0039_circuittermination_location.py (+20 -0)
📝 netbox/circuits/models/circuits.py (+10 -2)
📝 netbox/circuits/tables/circuits.py (+3 -1)
📝 netbox/templates/circuits/circuittermination_edit.html (+2 -0)
📝 netbox/templates/circuits/inc/circuit_termination.html (+4 -0)
📝 netbox/templates/dcim/inc/cable_termination.html (+8 -0)

📄 Description

Fixes: #9604

added location field to ProviderForm
added location foreign key to CircuitTermination
added location field to circuittermination_edit.html template
updated circuits table to display Side A/B value via this logic:

  • if location is set, show location
  • if site only is set, show site (as before)
  • if provider_network only is set, show provider_network (as before)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10458 **Author:** [@gjvc](https://github.com/gjvc) **Created:** 9/26/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `9604-add-location-to-circuittermination` --- ### 📝 Commits (7) - [`f193dd4`](https://github.com/netbox-community/netbox/commit/f193dd428160fba58571bbf2f0793a411bf1b825) add "Location" to CircuitTermination - [`d6e093f`](https://github.com/netbox-community/netbox/commit/d6e093f3449897ce15cc89af51ac19690526cbe0) minor diff cleanups - [`a2453c5`](https://github.com/netbox-community/netbox/commit/a2453c5b453bb0d0595a1c1df7f6d7413b11a6ab) update CIRCUITTERMINATION_LINK - [`623a739`](https://github.com/netbox-community/netbox/commit/623a739b522f6343d8d09fbd6d1518cd97b40715) update CIRCUITTERMINATION_LINK - [`54769af`](https://github.com/netbox-community/netbox/commit/54769afe437e1f0a3c6cf51e12f9fe74d9482952) CIRCUITTERMINATION_LINK -> CIRCUIT_TERMINATION_LINK - [`24cc5ed`](https://github.com/netbox-community/netbox/commit/24cc5edcfb895288b50c008023af646e364c3688) Merge branch 'develop' into 9604-add-location-to-circuittermination - [`9901091`](https://github.com/netbox-community/netbox/commit/9901091459a29e1566451de891107281dae25833) cleanup ### 📊 Changes **7 files changed** (+57 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms/models.py` (+10 -2) ➕ `netbox/circuits/migrations/0039_circuittermination_location.py` (+20 -0) 📝 `netbox/circuits/models/circuits.py` (+10 -2) 📝 `netbox/circuits/tables/circuits.py` (+3 -1) 📝 `netbox/templates/circuits/circuittermination_edit.html` (+2 -0) 📝 `netbox/templates/circuits/inc/circuit_termination.html` (+4 -0) 📝 `netbox/templates/dcim/inc/cable_termination.html` (+8 -0) </details> ### 📄 Description ### Fixes: #9604 added location field to ProviderForm added location foreign key to CircuitTermination added location field to circuittermination_edit.html template updated circuits table to display Side A/B value via this logic: - if location is set, show location - if site only is set, show site (as before) - if provider_network only is set, show provider_network (as before) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:59 +01:00
adam closed this issue 2025-12-29 23:19:59 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?