starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10349] [MERGED] Fixes #10305: Allows null master in VirtualChassis APIs #13615

New Issue
Closed
opened 2025-12-29 23:19:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10349
Author: @sasschary
Created: 9/13/2022
Status: ✅ Merged
Merged: 9/14/2022
Merged by: @jeremystretch

Base: develop ← Head: 10316-cableform-termination

📝 Commits (1)

  • ace66ea Fixes #10305: Allows null master in VirtualChassis APIs

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+1 -1)
📝 netbox/dcim/tests/test_api.py (+1 -0)

📄 Description

Fixes: #10305

VirtualChassis API calls were not allowing the master field to be null. This PR allows the field to be null and adds a test to verify that the field can be set to null.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10349 **Author:** [@sasschary](https://github.com/sasschary) **Created:** 9/13/2022 **Status:** ✅ Merged **Merged:** 9/14/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10316-cableform-termination` --- ### 📝 Commits (1) - [`ace66ea`](https://github.com/netbox-community/netbox/commit/ace66eab61f53294a78a8ede48cf73d17518e8f0) Fixes #10305: Allows null master in VirtualChassis APIs ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+1 -1) 📝 `netbox/dcim/tests/test_api.py` (+1 -0) </details> ### 📄 Description ### Fixes: #10305 VirtualChassis API calls were not allowing the `master` field to be `null`. This PR allows the field to be null and adds a test to verify that the field can be set to `null`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:52 +01:00
adam closed this issue 2025-12-29 23:19:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?