[PR #10338] [MERGED] Introduce pyproject.toml #13611

Closed
opened 2025-12-29 23:19:51 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10338
Author: @jsenecal
Created: 9/12/2022
Status: Merged
Merged: 9/12/2022
Merged by: @jeremystretch

Base: developHead: 10298-pyproject-toml


📝 Commits (1)

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

pyproject.toml (+13 -0)

📄 Description

Fixes: #10298

Introduces a pyproject.toml (see PEP 518) file to define some of the linting rules used in the project such as line length and the usage of single-quote strings.

This PR provides a basic pyproject.toml with simple rules for black, isort and pylint tweaked to not break the existing codebase... too much.

The current pre-commit hook which (among other things) runs pycodestyle with a few arguments to control the rules being applied does not format code but will prevent non PEP8 code submissions to be committed. This PR does not alter this behavior.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10338 **Author:** [@jsenecal](https://github.com/jsenecal) **Created:** 9/12/2022 **Status:** ✅ Merged **Merged:** 9/12/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10298-pyproject-toml` --- ### 📝 Commits (1) - [`d078bef`](https://github.com/netbox-community/netbox/commit/d078befd33f7c0aabe5cc9717db13886cda40985) Introduce pyproject.toml ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `pyproject.toml` (+13 -0) </details> ### 📄 Description ### Fixes: #10298 Introduces a `pyproject.toml` (see [PEP 518](https://peps.python.org/pep-0518/)) file to define some of the linting rules used in the project such as line length and the usage of single-quote strings. This PR provides a _basic_ `pyproject.toml` with simple rules for black, isort and pylint tweaked to not break the existing codebase... too much. The current pre-commit hook which (among other things) runs pycodestyle with a few arguments to control the rules being applied does not format code but will prevent non PEP8 code submissions to be committed. This PR does not alter this behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:51 +01:00
adam closed this issue 2025-12-29 23:19:51 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13611