starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10296] [MERGED] Fixes #10294 - Don't return empty string for empty wwn form field #13603

New Issue
Closed
opened 2025-12-29 23:19:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10296
Author: @kkthxbye-code
Created: 9/8/2022
Status: ✅ Merged
Merged: 9/8/2022
Merged by: @jeremystretch

Base: develop ← Head: 10294-fix-wwn-changelog

📝 Commits (1)

  • 3dbc7bd Add wwn CharField to InterfaceForm

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 netbox/dcim/forms/models.py (+6 -0)

📄 Description

Fixes: #10294

Adds wwn as a CharField with empty_value set to None. This fixes the spurious changes in changelogs when the field is empty.

This is equivalent with the mac address field but wwn is only present on device interfaces and not vm interfaces which was probably why it was missed when it was added.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10296 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 9/8/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `10294-fix-wwn-changelog` --- ### 📝 Commits (1) - [`3dbc7bd`](https://github.com/netbox-community/netbox/commit/3dbc7bdd2c78583902733e6a9a7d59d7ce07d649) Add wwn CharField to InterfaceForm ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/models.py` (+6 -0) </details> ### 📄 Description ### Fixes: #10294 Adds wwn as a CharField with empty_value set to None. This fixes the spurious changes in changelogs when the field is empty. [This is equivalent with the mac address field](https://github.com/netbox-community/netbox/blob/b7028228578066b81e5f26d83cbba6c303401efe/netbox/dcim/forms/common.py#L12-L15) but wwn is only present on device interfaces and not vm interfaces which was probably why it was missed when it was added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:48 +01:00
adam closed this issue 2025-12-29 23:19:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?