starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #10140] [CLOSED] Add "Assign FHRP Group" to device-interfaces context menu #13564

New Issue
Closed
opened 2025-12-29 23:19:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10140
Author: @arthanson
Created: 8/25/2022
Status: ❌ Closed

Base: develop ← Head: art-10038

📝 Commits (2)

  • 9f827a8 #10038 add L2VPN termination to interface list context menu
  • ddba785 Merge branch 'develop' into art-10038

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 netbox/dcim/tables/template_code.py (+3 -0)

📄 Description

Fixes: #10038

Adds an "Assign FHRP Group" to the context menu of devices-interfaces (see screenshot). Couple potential changes/questions:

  1. This is an add button, so I'm not sure of putting an "assignment" in here if there is a convention? Potentially rename it to "FHRP Group - Assign"
  2. The feature request also had "Add FHRP Group" going to a separate page that had tabs for each of add and assign. I didn't see any existing convention for this type of page currently? Would require refactoring of the code to avoid code-duplication.
  3. could add "Add FHRP Group" as a separate menu item - but that isn't tied at all to the particular interface so seems like an over-loading of the context menu?

assign-fhrp

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10140 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 8/25/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `art-10038` --- ### 📝 Commits (2) - [`9f827a8`](https://github.com/netbox-community/netbox/commit/9f827a895c208b7beeef043d539dbd458e0b283c) #10038 add L2VPN termination to interface list context menu - [`ddba785`](https://github.com/netbox-community/netbox/commit/ddba785217727a7994c9e16cddd54df576b4b22d) Merge branch 'develop' into art-10038 ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/template_code.py` (+3 -0) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ACCEPTED BUG REPORT OR FEATURE REQUEST, IT WILL BE MARKED AS INVALID AND CLOSED. --> ### Fixes: #10038 <!-- Please include a summary of the proposed changes below. --> Adds an "Assign FHRP Group" to the context menu of devices-interfaces (see screenshot). Couple potential changes/questions: 1. This is an add button, so I'm not sure of putting an "assignment" in here if there is a convention? Potentially rename it to "FHRP Group - Assign" 2. The feature request also had "Add FHRP Group" going to a separate page that had tabs for each of add and assign. I didn't see any existing convention for this type of page currently? Would require refactoring of the code to avoid code-duplication. 3. could add "Add FHRP Group" as a separate menu item - but that isn't tied at all to the particular interface so seems like an over-loading of the context menu? ![assign-fhrp](https://user-images.githubusercontent.com/99642/186532716-24f8f3f3-ca69-4246-85a6-77ef9c0bfd82.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:35 +01:00
adam closed this issue 2025-12-29 23:19:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?