starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #9752] [MERGED] Fixes #9730 - Fix CableForm Validation for #9102 #13514

New Issue
Closed
opened 2025-12-29 23:19:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/9752
Author: @mzbroch
Created: 7/17/2022
Status: ✅ Merged
Merged: 7/18/2022
Merged by: @jeremystretch

Base: feature ← Head: mzb-9102#2

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 netbox/dcim/forms/connections.py (+2 -3)

📄 Description

Fixes: #9730

Moving assignment of Cable A/B terminations inside a CableForm from save to clean method.

Having them in .save() method of form resulted in raising ValidationError("Must define A and B terminations when creating a new cable.") in a Cable model validation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/9752 **Author:** [@mzbroch](https://github.com/mzbroch) **Created:** 7/17/2022 **Status:** ✅ Merged **Merged:** 7/18/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `mzb-9102#2` --- ### 📝 Commits (1) - [`58b191b`](https://github.com/netbox-community/netbox/commit/58b191b439462316229fdf3ecc5d3ac0461e3513) Fix CableForm Validation for #9102 ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/connections.py` (+2 -3) </details> ### 📄 Description ### Fixes: #9730 Moving assignment of Cable A/B terminations inside a CableForm from `save` to `clean` method. Having them in `.save()` method of form resulted in raising `ValidationError("Must define A and B terminations when creating a new cable.")` in a `Cable` model validation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:17 +01:00
adam closed this issue 2025-12-29 23:19:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13514
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?