starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #9750] [MERGED] Fixes #9634: Respect image URLs which are already fully formed #13513

New Issue
Closed
opened 2025-12-29 23:19:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/9750
Author: @smuth4
Created: 7/16/2022
Status: ✅ Merged
Merged: 7/19/2022
Merged by: @jeremystretch

Base: develop ← Head: fix/broken-image-urls

📝 Commits (1)

  • 3d475e5 Fixes #9634: Respect image URLs which are already fully formed

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 netbox/dcim/svg.py (+10 -2)

📄 Description

Fixes: #9634

I kept the change simple, tested with local and s3 storage. Fully parsing the URL seemed like overkill, but I can do that if desired.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/9750 **Author:** [@smuth4](https://github.com/smuth4) **Created:** 7/16/2022 **Status:** ✅ Merged **Merged:** 7/19/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix/broken-image-urls` --- ### 📝 Commits (1) - [`3d475e5`](https://github.com/netbox-community/netbox/commit/3d475e5afa2bbee182d33d6f9e2b08b42e6fa866) Fixes #9634: Respect image URLs which are already fully formed ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/svg.py` (+10 -2) </details> ### 📄 Description ### Fixes: #9634 I kept the change simple, tested with local and s3 storage. Fully parsing the URL seemed like overkill, but I can do that if desired. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:17 +01:00
adam closed this issue 2025-12-29 23:19:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?