starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #9615] [MERGED] Closes #9102: Add support for multi-termination cable ends #13500

New Issue
Closed
opened 2025-12-29 23:19:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:19:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/9615
Author: @jeremystretch
Created: 6/27/2022
Status: ✅ Merged
Merged: 7/8/2022
Merged by: @jeremystretch

Base: feature ← Head: 9102-cabling

📝 Commits (10+)

  • c48c8cc Remove termination IDs from cable creation view paths
  • 6c29035 Allow editing A side termination when creating cable
  • 4bb9b6e Extend Cable model to support multiple A/B terminations
  • e0fc1b4 Remove errant print statement
  • 907323d Revert initial model changes
  • 1f4ad44 Introduce CableTermination model & migrate data
  • 5d37f9f Update cable connection forms
  • c3742f6 Update signal handlers (WIP)
  • f0fc8bf Restrict A terminations by parent object
  • c220079 Ensure cable is cached on terminating endpoints

📊 Changes

65 files changed (+3373 additions, -2220 deletions)

View changed files

📝 docs/release-notes/version-3.3.md (+85 -1)
📝 netbox/circuits/api/serializers.py (+5 -6)
📝 netbox/circuits/api/views.py (+1 -1)
📝 netbox/circuits/filtersets.py (+3 -3)
📝 netbox/circuits/graphql/types.py (+2 -1)
➖ netbox/circuits/migrations/0036_circuit_termination_date.py (+0 -18)
📝 netbox/circuits/migrations/0036_circuit_termination_date_tags_custom_fields.py (+6 -2)
➕ netbox/circuits/migrations/0037_new_cabling_models.py (+16 -0)
➕ netbox/circuits/migrations/0038_cabling_cleanup.py (+20 -0)
📝 netbox/circuits/models/circuits.py (+2 -2)
📝 netbox/circuits/signals.py (+1 -1)
📝 netbox/circuits/tests/test_filtersets.py (+1 -1)
📝 netbox/circuits/tests/test_views.py (+1 -1)
📝 netbox/circuits/urls.py (+1 -2)
📝 netbox/dcim/api/serializers.py (+127 -121)
📝 netbox/dcim/api/urls.py (+1 -0)
📝 netbox/dcim/api/views.py (+38 -39)
📝 netbox/dcim/choices.py (+16 -0)
📝 netbox/dcim/constants.py (+2 -0)
📝 netbox/dcim/filtersets.py (+62 -38)

...and 45 more files

📄 Description

Closes: #9102

  • Replaces the termination_a and termination_b GFK fields on Cable with a new CableTermination model
  • Updates CablePath's path field to convey multiple nodes per "hop"

There's a lot more to list here obviously, but I wanted to get the PR started for review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/9615 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/27/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `9102-cabling` --- ### 📝 Commits (10+) - [`c48c8cc`](https://github.com/netbox-community/netbox/commit/c48c8cc353efc21a20a7c67fa435c19619ef6359) Remove termination IDs from cable creation view paths - [`6c29035`](https://github.com/netbox-community/netbox/commit/6c290353c1162d7b01c10089170705e86c6ffc02) Allow editing A side termination when creating cable - [`4bb9b6e`](https://github.com/netbox-community/netbox/commit/4bb9b6ee2639db683b70d6ddbee055497e0a3647) Extend Cable model to support multiple A/B terminations - [`e0fc1b4`](https://github.com/netbox-community/netbox/commit/e0fc1b4f41b38fa700ab452793b33b477d9ea72b) Remove errant print statement - [`907323d`](https://github.com/netbox-community/netbox/commit/907323d46fd1b507c08f89cd750774969801ae49) Revert initial model changes - [`1f4ad44`](https://github.com/netbox-community/netbox/commit/1f4ad444ae488be0667ae329de945c6d537036e0) Introduce CableTermination model & migrate data - [`5d37f9f`](https://github.com/netbox-community/netbox/commit/5d37f9f9759b0b31bf0e4fd8fdb7964ff3729abf) Update cable connection forms - [`c3742f6`](https://github.com/netbox-community/netbox/commit/c3742f63fd01e4dafa79318646c85c651a496221) Update signal handlers (WIP) - [`f0fc8bf`](https://github.com/netbox-community/netbox/commit/f0fc8bf2cf40b669ba9b412f79d9666dafc8322e) Restrict A terminations by parent object - [`c220079`](https://github.com/netbox-community/netbox/commit/c22007939b9447a0100f3318a3b7579efdbb0d91) Ensure cable is cached on terminating endpoints ### 📊 Changes **65 files changed** (+3373 additions, -2220 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-3.3.md` (+85 -1) 📝 `netbox/circuits/api/serializers.py` (+5 -6) 📝 `netbox/circuits/api/views.py` (+1 -1) 📝 `netbox/circuits/filtersets.py` (+3 -3) 📝 `netbox/circuits/graphql/types.py` (+2 -1) ➖ `netbox/circuits/migrations/0036_circuit_termination_date.py` (+0 -18) 📝 `netbox/circuits/migrations/0036_circuit_termination_date_tags_custom_fields.py` (+6 -2) ➕ `netbox/circuits/migrations/0037_new_cabling_models.py` (+16 -0) ➕ `netbox/circuits/migrations/0038_cabling_cleanup.py` (+20 -0) 📝 `netbox/circuits/models/circuits.py` (+2 -2) 📝 `netbox/circuits/signals.py` (+1 -1) 📝 `netbox/circuits/tests/test_filtersets.py` (+1 -1) 📝 `netbox/circuits/tests/test_views.py` (+1 -1) 📝 `netbox/circuits/urls.py` (+1 -2) 📝 `netbox/dcim/api/serializers.py` (+127 -121) 📝 `netbox/dcim/api/urls.py` (+1 -0) 📝 `netbox/dcim/api/views.py` (+38 -39) 📝 `netbox/dcim/choices.py` (+16 -0) 📝 `netbox/dcim/constants.py` (+2 -0) 📝 `netbox/dcim/filtersets.py` (+62 -38) _...and 45 more files_ </details> ### 📄 Description ### Closes: #9102 - Replaces the `termination_a` and `termination_b` GFK fields on Cable with a new CableTermination model - Updates CablePath's `path` field to convey multiple nodes per "hop" There's a lot more to list here obviously, but I wanted to get the PR started for review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:19:14 +01:00
adam closed this issue 2025-12-29 23:19:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13500
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?